feat: Modified return value of GetModCompatibilities

Author: rhit-zhangl8

generated/generated.go

@@ -325,6 +325,10 @@ func (r *queryResolver) GetModCompatibilities(ctx context.Context, modpackID str
 	// build list of mods that are causing the pack to have that compatibility state
 	eaWorstList := []*generated.Mod{}
 	expWorstList := []*generated.Mod{}
+	compatibilityState := generated.CompatibilityInfo{
+		Ea:  &generated.Compatibility{State: packWorstEaState, Note: nil},
+		Exp: &generated.Compatibility{State: packWorstExpState, Note: nil},
+	}
 	packIsNotBothWorks := packWorstEaState != generated.CompatibilityStateWorks || packWorstExpState != generated.CompatibilityStateWorks
 	if packIsNotBothWorks {
 		for _, mod := range mods {
@@ -339,11 +343,8 @@ func (r *queryResolver) GetModCompatibilities(ctx context.Context, modpackID str
 				}
 			}
 		}
-		return &generated.ModCompatibilities{WorstEa: eaWorstList, WorstExp: expWorstList}, nil
-
-	} else {
-		return &generated.ModCompatibilities{WorstEa: generated.CompatibilityStateWorks, WorstExp: generated.CompatibilityStateWorks}, nil
 	}
+	return &generated.ModCompatibilities{Compatibility: &compatibilityState, WorstEa: eaWorstList, WorstExp: expWorstList}, nil
 }
 
 func (r *mutationResolver) CreateModpackRelease(ctx context.Context, modpackID string, release generated.NewModpackRelease) (*generated.ModpackRelease, error) {

generated/models_gen.go

@@ -60,6 +60,7 @@ type GetModpacks {
 }
 
 type ModCompatibilities{
+    compatibility: CompatibilityInfo
     worstEA: [Mod!]!
     worstEXP: [Mod!]!
 }

gql/resolver_modpacks.go

@@ -158,11 +158,11 @@ func TestModpackCompatibility(t *testing.T) {
 
 		testza.AssertEqual(t, 1, len(queryResponse.GetModCompatibilities.WorstEa))
 		testza.AssertEqual(t, mods[0], queryResponse.GetModCompatibilities.WorstEa[0].ID)
-		testza.AssertEqual(t, generated.CompatibilityStateBroken, queryResponse.GetModCompatibilities.WorstEa[0].Compatibility.Ea.State)
+		testza.AssertEqual(t, generated.CompatibilityStateBroken, queryResponse.GetModCompatibilities.Compatibility.Ea.State)
 
 		testza.AssertEqual(t, 1, len(queryResponse.GetModCompatibilities.WorstExp))
 		testza.AssertEqual(t, mods[1], queryResponse.GetModCompatibilities.WorstExp[0].ID)
-		testza.AssertEqual(t, generated.CompatibilityStateDamaged, queryResponse.GetModCompatibilities.WorstExp[0].Compatibility.Exp.State)
+		testza.AssertEqual(t, generated.CompatibilityStateDamaged, queryResponse.GetModCompatibilities.Compatibility.Exp.State)
 	})
 
 	t.Run("Multi mod compatibility", func(t *testing.T) {
@@ -249,7 +249,7 @@ func TestModpackCompatibility(t *testing.T) {
 		testza.AssertNoError(t, err)
 
 		testza.AssertEqual(t, 2, len(queryResponse.GetModCompatibilities.WorstEa))
-		testza.AssertEqual(t, generated.CompatibilityStateBroken, queryResponse.GetModCompatibilities.WorstEa[0].Compatibility.Ea.State)
+		testza.AssertEqual(t, generated.CompatibilityStateBroken, queryResponse.GetModCompatibilities.Compatibility.Ea.State)
 		testza.AssertEqual(t, 0, len(queryResponse.GetModCompatibilities.WorstExp))
 	})
 }