Replies: 2 comments 4 replies
-
|
I guess you could covert this discussion in an issue, I guess it gonna be a nice feature. |
Beta Was this translation helpful? Give feedback.
3 replies
-
|
@yousef8 |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi all,
I'm a native arabic speaker and i recently forked astro-paper theme to make my blog which will be in arabic.
To make this transition for the theme to be compatible with arabic which is a RTL (right to left) lang, first step was to edit the tailwind styling to be direction agnostic which mean the theme layout direction can be RTL or LTR without messing the styling this was relatively easy thanks to the css logical properties that helps to make the UI layout direction agnostic through logical properties
margin-inline-startandmargin-inline-endand this was first adopted in tailwind in version 3.3 , here is the PR that first introduced this feature to tailwind for more info.After i finished this step, I figured that i can submit a PR to add this feature to the main theme which can be useful to anyone in the future that would want to utilize the theme for any other RTL language , and to save them a step they would have to do.
I know this can add an extra thing to keep in mind when mainting the theme, but i can offer that i will maintain this feature as i already will be syncing my fork with yours and if there is any bug i will issue a fix for it.
Here is my current branch with the proposed feature you can inspect the commits and you will see the changes is very minimal.
Beta Was this translation helpful? Give feedback.
All reactions