fix: Don't skip log printing if job has an id and has completed (#1013)

mhan83 · web-flow · commit 47a3ed693b16 · 2025-02-12T09:28:36.000-07:00
diff --git a/internal/saucecloud/cloud.go b/internal/saucecloud/cloud.go
@@ -803,8 +803,10 @@ func (r *CloudRunner) logSuite(ctx context.Context, res result) {
 			logger.Error().Err(res.err).Msg("Suite failed to start.")
 			return
 		}
-		logger.Error().Err(res.err).Msg("Suite failed unexpectedly.")
-		return
+		if !job.Done(res.job.Status) {
+			logger.Error().Err(res.err).Msg("Suite failed unexpectedly.")
+			return
+		}
 	}
 
 	// Job isn't done, hence nothing more to log about it.

Original file line number	Diff line number	Diff line change
`@@ -803,8 +803,10 @@ func (r *CloudRunner) logSuite(ctx context.Context, res result) {`
`803`	`803`	`logger.Error().Err(res.err).Msg("Suite failed to start.")`
`804`	`804`	`return`
`805`	`805`	`}`
`806`		`- logger.Error().Err(res.err).Msg("Suite failed unexpectedly.")`
`807`		`- return`
	`806`	`+ if !job.Done(res.job.Status) {`
	`807`	`+ logger.Error().Err(res.err).Msg("Suite failed unexpectedly.")`
	`808`	`+ return`
	`809`	`+ }`
`808`	`810`	`}`
`809`	`811`
`810`	`812`	`// Job isn't done, hence nothing more to log about it.`