always finishe created builds

Author: aga-szczepanska

Diff for: visual-js/visual-snapshots/src/app/pdf-handler.ts

@@ -12,28 +12,43 @@ export interface PdfCommandParams
   concurrency: number;
 }
 
+export enum PdfCommandStatus {
+  SUCCESS,
+  FAILURE,
+}
+
 export class PdfCommandHandler {
   constructor(
     private readonly visualSnapshotsApi: VisualSnapshotsApi,
     private readonly pdfSnapshotUploader: PdfSnapshotUploader
   ) {}
 
-  public async handle(globsOrDirs: string[], params: PdfCommandParams) {
+  public async handle(
+    globsOrDirs: string[],
+    params: PdfCommandParams
+  ): Promise<PdfCommandStatus> {
     const pdfFilePaths = await getFiles(globsOrDirs, "*.pdf");
 
     const buildId =
       params.buildId ?? (await this.visualSnapshotsApi.createBuild(params));
 
-    await this.pdfSnapshotUploader.uploadSnapshots({
-      buildId,
-      pdfFilePaths,
-      suiteName: params.suiteName,
-      testNameFormat: params.testName,
-      snapshotNameFormat: params.snapshotName,
-    });
+    let status: PdfCommandStatus;
+    try {
+      await this.pdfSnapshotUploader.uploadSnapshots({
+        buildId,
+        pdfFilePaths,
+        suiteName: params.suiteName,
+        testNameFormat: params.testName,
+        snapshotNameFormat: params.snapshotName,
+      });
+      status = PdfCommandStatus.SUCCESS;
+    } catch (_) {
+      status = PdfCommandStatus.FAILURE;
+    }
 
     if (!params.buildId) {
       await this.visualSnapshotsApi.finishBuild(buildId);
     }
+    return status;
   }
 }

Diff for: visual-js/visual-snapshots/src/commands/pdf.ts

@@ -12,7 +12,11 @@ import {
   suiteNameOption,
   usernameOption,
 } from "./options.js";
-import { PdfCommandHandler, PdfCommandParams } from "../app/pdf-handler.js";
+import {
+  PdfCommandHandler,
+  PdfCommandParams,
+  PdfCommandStatus,
+} from "../app/pdf-handler.js";
 import { EOL } from "os";
 import { VisualSnapshotsApi } from "../api/visual-snapshots-api.js";
 import { initializeVisualApi } from "../api/visual-client.js";
@@ -67,11 +71,19 @@ export const pdfCommand = (clientVersion: string) => {
 
       new PdfCommandHandler(visualSnapshotsApi, pdfSnapshotUploader)
         .handle(globsOrDirs, params)
-        .then(() => {
-          console.log("Successfully created PDF snapshots");
+        .then((status: PdfCommandStatus) => {
+          if (status == PdfCommandStatus.SUCCESS) {
+            console.info("Successfully created PDF snapshots.");
+          } else {
+            console.error(
+              "At least one PDF snapshot creation failed. Please contact Sauce Labs customer support."
+            );
+          }
         })
         .catch((err) => {
-          console.error(`An error occured when creating PDF snapshots: ${err}`);
+          console.error(
+            `An unexpected error occured when creating PDF snapshots: ${err}. Please contact Sauce Labs customer support.`
+          );
         });
     });
 };