Skip to content

Commit 7ab1392

Browse files
committed
Selective diffing for nightwach
1 parent acc3725 commit 7ab1392

File tree

2 files changed

+17
-6
lines changed

2 files changed

+17
-6
lines changed

visual-js/visual-nightwatch/nightwatch/commands/sauceVisualCheck.js

+12-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
const EventEmitter = require('events').EventEmitter;
2-
const { ensureError, getFullPageConfig } = require('@saucelabs/visual');
2+
const {
3+
ensureError,
4+
getFullPageConfig,
5+
selectiveRegionsToRegionIn,
6+
} = require('@saucelabs/visual');
37
const { parseIgnoreOptions, toIgnoreRegionIn } = require('../../utils/regions');
48
const { getMetaInfo, getVisualApi } = require('../../utils/api');
59
const { VISUAL_BUILD_ID_KEY } = require('../../utils/constants');
@@ -49,6 +53,13 @@ module.exports = class SauceVisualCheck extends EventEmitter {
4953
? await toIgnoreRegionIn(resolvedIgnoreOptions)
5054
: [];
5155
//
56+
// Regions
57+
const regions = await selectiveRegionsToRegionIn(
58+
options.regions ?? [],
59+
toIgnoreRegionIn,
60+
);
61+
ignoreRegions.push(...regions);
62+
//
5263
// Get more info about the session
5364
const {
5465
capabilities,

visual-js/yarn.lock

+5-5
Original file line numberDiff line numberDiff line change
@@ -2829,7 +2829,7 @@ __metadata:
28292829
version: 0.0.0-use.local
28302830
resolution: "@saucelabs/cypress-visual-plugin@workspace:visual-cypress"
28312831
dependencies:
2832-
"@saucelabs/visual": 0.4.0
2832+
"@saucelabs/visual": 0.5.0
28332833
"@tsconfig/node18": ^2.0.1
28342834
"@types/cypress": ^1.1.3
28352835
"@types/node": ^20.4.4
@@ -2858,7 +2858,7 @@ __metadata:
28582858
version: 0.0.0-use.local
28592859
resolution: "@saucelabs/nightwatch-sauce-visual-service@workspace:visual-nightwatch"
28602860
dependencies:
2861-
"@saucelabs/visual": 0.4.0
2861+
"@saucelabs/visual": 0.5.0
28622862
chalk: ^4.1.2
28632863
concurrently: ^8.2.2
28642864
eslint: ^8.0.1
@@ -2876,7 +2876,7 @@ __metadata:
28762876
resolution: "@saucelabs/visual-storybook@workspace:visual-storybook"
28772877
dependencies:
28782878
"@jest/globals": ^28.0.0 || ^29.0.0
2879-
"@saucelabs/visual": 0.4.0
2879+
"@saucelabs/visual": 0.5.0
28802880
"@storybook/test-runner": ">=0.13.0"
28812881
"@storybook/types": ^8.0.2
28822882
"@tsconfig/node18": ^2.0.0
@@ -2904,7 +2904,7 @@ __metadata:
29042904
languageName: unknown
29052905
linkType: soft
29062906

2907-
"@saucelabs/visual@0.4.0, @saucelabs/visual@workspace:visual":
2907+
"@saucelabs/visual@0.5.0, @saucelabs/visual@workspace:visual":
29082908
version: 0.0.0-use.local
29092909
resolution: "@saucelabs/visual@workspace:visual"
29102910
dependencies:
@@ -2949,7 +2949,7 @@ __metadata:
29492949
resolution: "@saucelabs/wdio-sauce-visual-service@workspace:visual-wdio"
29502950
dependencies:
29512951
"@jest/globals": ^29.7.0
2952-
"@saucelabs/visual": 0.4.0
2952+
"@saucelabs/visual": 0.5.0
29532953
"@tsconfig/node18": ^2.0.0
29542954
"@types/jest": ^29.5.6
29552955
"@typescript-eslint/eslint-plugin": ^5.59.1

0 commit comments

Comments
 (0)