[INT-1] visual-snapshots: fix PdfConverter

Author: perf2711

Diff for: visual-js/visual-snapshots/src/app/pdf-converter.ts

@@ -7,7 +7,11 @@ export class PdfConverter {
   public async *convertPagesToImages(
     pdfFilePath: string
   ): AsyncGenerator<Buffer> {
-    return await this._pdf(pdfFilePath, { scale: 1 });
+    for await (const pdfPageImage of await this._pdf(pdfFilePath, {
+      scale: 1,
+    })) {
+      yield pdfPageImage;
+    }
   }
 
   public createPdfFile(pdfFilePath: string): PdfFile {

Diff for: visual-js/visual-snapshots/test/app/pdf-converter.spec.ts

@@ -1,8 +1,10 @@
+import path from "path";
 import { PdfConverter } from "../../src/app/pdf-converter.js";
+import { __dirname } from "../helpers.js";
 
 describe("PdfConverter", () => {
   test("convertPagesToImages", async () => {
-    const pdf = jest.fn();
+    const pdf = jest.fn().mockResolvedValue([]);
 
     const pdfFilePath = "./fake-pdf-file-path.pdf";
     const pdfConverter = new PdfConverter(pdf);
@@ -12,8 +14,20 @@ describe("PdfConverter", () => {
     expect(pdf).toHaveBeenCalledWith(pdfFilePath, { scale: 1 });
   });
 
+  test("convertPagesToImages", async () => {
+    const pdfFilePath = path.join(__dirname(import.meta), "../files/test.pdf");
+    const pdfConverter = new PdfConverter();
+
+    let pages = 0;
+    for await (const _ of pdfConverter.convertPagesToImages(pdfFilePath)) {
+      pages++;
+    }
+
+    expect(pages).toEqual(3);
+  });
+
   test("createPdfFile", async () => {
-    const pdf = jest.fn();
+    const pdf = jest.fn().mockResolvedValue([]);
     const pdfConverter = new PdfConverter(pdf);
 
     const pdfFilePath = "./fake-pdf-file-path.pdf";