fix: require explicit action for image paste and restore reliable trigger

- Remove clipboard badge ([📋]) from the prompt entirely
- Keep image insertion explicit only (/img or Ctrl+V event when terminal forwards it)
- Drop watcher-driven UI state/dismissal loop and related stale state paths
- Make Ctrl+V (\x16) and empty bracketed paste trigger /img directly without waiting for watcher flag timing
- Preserve multi-image support via repeated explicit insertions in one line

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: sultanAalyami

src/core/input.js

@@ -98,18 +98,11 @@ class RawInput extends EventEmitter {
   _onData(raw) {
     const data = raw;
 
-    // ── Ctrl+V raw byte (\x16) — only arrives when terminal cannot paste text
-    //    (e.g. clipboard holds an image, or non-WT terminal). When watcher
-    //    confirms image in clipboard → insert /img to trigger inline capture.
-    //    When no watcher or no image → fall through (WT handles text via
-    //    bracketed paste and we never receive \x16 for text anyway).
+    // ── Ctrl+V raw byte (\x16) — explicit user action to paste image context.
+    // We trigger /img immediately (no watcher gating) so capture is reliable
+    // even if clipboard watcher state is momentarily stale.
     if (data === '\x16') {
-      if (!this._paused) {
-        if (this._hasImageFn && this._hasImageFn()) {
-          this._insertImgCommand();
-        }
-        // else: terminal is handling paste via bracketed paste sequence
-      }
+      if (!this._paused) this._insertImgCommand();
       return;
     }
 
@@ -167,10 +160,8 @@ class RawInput extends EventEmitter {
         this._insert(pasted);
         this._redraw();
       } else {
-        // Empty text paste — clipboard had image only; trigger /img if confirmed
-        if (!this._paused && this._hasImageFn && this._hasImageFn()) {
-          this._insertImgCommand();
-        }
+        // Empty paste payload is treated as explicit image-paste intent.
+        if (!this._paused) this._insertImgCommand();
       }
       return;
     }

src/core/repl.js

@@ -17,14 +17,10 @@ const BRAND = '⟩⟨';
 // Lazy-loaded to avoid startup cost
 function imgpaste() { return require('../utils/imgpaste'); }
 
-// Dynamic prompt — mirrors PowerShell style, with optional clipboard indicator.
-// imgReady = true adds [📋] hint so user knows they can type /img.
-function makePrompt(imgReady) {
+// Dynamic prompt — mirrors PowerShell style.
+function makePrompt() {
   const cwd = process.cwd();
-  const base = `\x1b[90mPS ${cwd}>\x1b[0m \x1b[1;96m${BRAND}\x1b[0m `;
-  return imgReady
-    ? base + `\x1b[33m[📋]\x1b[0m `
-    : base;
+  return `\x1b[90mPS ${cwd}>\x1b[0m \x1b[1;96m${BRAND}\x1b[0m `;
 }
 
 const HELP_TEXT = `
@@ -289,16 +285,12 @@ class SarmadRepl {
 
   async start() {
     // ── Clipboard watcher ─────────────────────────────────────────────────────
-    // Detects images in clipboard without relying on Ctrl+V (which Windows
-    // Terminal intercepts). Background watcher stores clipboard sequence id
-    // for image state, so we can dismiss stale images correctly.
+    // Detect clipboard image presence for explicit image insert actions
+    // (/img, Ctrl+V when forwarded by terminal, empty image paste fallback).
     const watcher = new ClipboardWatcher();
     watcher.start();
 
-    let _imgReady = false;
-    let _lastSeq = null;       // latest clipboard sequence with image
-    let _dismissedSeq = null;  // sequence user dismissed by deleting token
-    const getPrompt = () => makePrompt(_imgReady);
+    const getPrompt = () => makePrompt();
 
     const rawInput = new RawInput({
       history: this.history
@@ -308,50 +300,8 @@ class SarmadRepl {
       hasImageFn: () => watcher.hasImage(),
     });
 
-    // ── Clipboard watcher interval ────────────────────────────────────────────
-    // Uses clipboard sequence numbers to avoid stale state:
-    // - No auto-capture while line is active (UX is explicit, not surprising)
-    // - Deleting a token dismisses current sequence (hide [📋], no stale reinsert)
-    // - Any clipboard change clears dismissal automatically
-    const _watchInterval = setInterval(() => {
-      if (rawInput._paused) return;
-      const { hasImage, seq } = watcher.getState();
-
-      // Clipboard has no image: clear all image-related transient state
-      if (!hasImage || !seq) {
-        _lastSeq = null;
-        _dismissedSeq = null;
-        if (_imgReady) {
-          _imgReady = false;
-          rawInput.setPromptFn(getPrompt);
-          rawInput._redraw();
-        }
-        return;
-      }
-
-      // New clipboard content cancels any prior dismissal.
-      if (_dismissedSeq !== null && seq !== _dismissedSeq) {
-        _dismissedSeq = null;
-      }
-
-      const isDismissed = (_dismissedSeq !== null && seq === _dismissedSeq);
-      const isNewSeq = (_lastSeq === null || seq !== _lastSeq);
-
-      if (isNewSeq) _lastSeq = seq;
-
-      // Indicator shown only when current sequence is not dismissed.
-      const wantIndicator = !isDismissed;
-      if (wantIndicator !== _imgReady) {
-        _imgReady = wantIndicator;
-        rawInput.setPromptFn(getPrompt);
-        rawInput._redraw();
-      }
-    }, 300);  // 300ms — fast clear/update with low overhead
-
     rawInput.on('line', async (line) => {
       rawInput.pause();
-      _imgReady = false;
-      rawInput.setPromptFn(getPrompt);
       try {
         await this.processInput(line);
       } catch (err) {
@@ -398,17 +348,6 @@ class SarmadRepl {
     rawInput.on('token-removed', (token) => {
       const m = token.match(/\[img:([A-Z0-9]{4})\]/);
       if (m) this._imgStore.delete(m[1]);
-      // User explicitly removed an image token: dismiss current clipboard image
-      // sequence so [📋] hides immediately and Enter won't re-capture it.
-      const st = watcher.getState();
-      if (st.hasImage && st.seq) {
-        _dismissedSeq = st.seq;
-        if (_imgReady) {
-          _imgReady = false;
-          rawInput.setPromptFn(getPrompt);
-          rawInput._redraw();
-        }
-      }
     });
 
     // ── Ctrl+C (single) — show hint ───────────────────────────────────────────
@@ -428,7 +367,6 @@ class SarmadRepl {
 
     // ── Double Ctrl+C — exit ──────────────────────────────────────────────────
     rawInput.on('exit', () => {
-      clearInterval(_watchInterval);
       watcher.stop();
       console.log(`\n${c.cyan}${BRAND}  مع السلامة!${R}\n`);
       saveHistory(this.history);
@@ -437,7 +375,6 @@ class SarmadRepl {
 
     // ── Ctrl+D ────────────────────────────────────────────────────────────────
     rawInput.on('close', () => {
-      clearInterval(_watchInterval);
       watcher.stop();
       console.log(`\n${c.cyan}${BRAND} Session ended. Goodbye!${R}\n`);
       saveHistory(this.history);