chore: update Codecov settings and fix pyright issues. (#1726)

* chore: update Codecov settings for coverage flags.

- ignore local  .claude folder

* fix pyright issues

Author: janfb

.github/codecov.yml

@@ -22,6 +22,21 @@ coverage:
         threshold: 2% # allow the coverage to drop by X%, and posting a success status
         if_ci_failed: error # will set the status to success only if the CI is successful, alternative: success
 
+# Flag configuration for carryforward
+# - 'fast': coverage from fast tests (run on every PR)
+# - 'full': coverage from full test suite including slow tests (run on main)
+#   carryforward ensures slow test coverage from main is included in PR reports
+flag_management:
+  individual_flags:
+    - name: fast
+      paths:
+        - sbi/
+      carryforward: false
+    - name: full
+      paths:
+        - sbi/
+      carryforward: true
+
 comment:
   layout: "diff, flags, files"
   behavior: default # update if exists, otherwise post new

.github/workflows/cd.yml

@@ -47,11 +47,11 @@ jobs:
       run: uv run pytest -v -x -n auto -m "not gpu" --cov=sbi --cov-report=xml --junitxml=junit.xml -o junit_family=legacy tests/
 
     - name: Upload coverage to Codecov
-      uses: codecov/codecov-action@v4-beta
+      uses: codecov/codecov-action@v4
       with:
         env_vars: OS,PYTHON
         file: ./coverage.xml
-        flags: unittests
+        flags: full
         name: codecov-sbi-all-cpu
         token: ${{ secrets.CODECOV_TOKEN }}
 

.github/workflows/ci.yml

@@ -61,7 +61,7 @@ jobs:
       with:
         env_vars: OS,PYTHON
         file: ./coverage.xml
-        flags: unittests
+        flags: fast
         name: codecov-sbi-fast-cpu
         token: ${{ secrets.CODECOV_TOKEN }}
 

.gitignore

@@ -105,3 +105,4 @@ uv.lock
 
 # Serena cache
 .serena/
+.claude/

pyproject.toml

@@ -157,7 +157,7 @@ xfail_strict = true
 [tool.pyright]
 include = ["sbi"]
 exclude = ["**/__pycache__", "**/__node_modules__", ".git", "docs", "mkdocs", "tests"]
-python_version = "3.10"
+pythonVersion = "3.10"
 reportUnsupportedDunderAll = false
 reportGeneralTypeIssues = false
 reportInvalidTypeForm = false

sbi/analysis/plot.py

@@ -1595,6 +1595,7 @@ def _sbc_rank_plot(
     if num_bins is None:
         # Recommendation from Talts et al.
         num_bins = num_sbc_runs // 20
+    assert isinstance(num_bins, int)
 
     # Plot one row subplot for each parameter, different "methods" on top of each other.
     if params_in_subplots:

sbi/inference/trainers/base.py

@@ -1288,7 +1288,7 @@ def __setstate__(self, state_dict: Dict):
             state_dict: State to be restored.
         """
         state_dict["_summary_writer"] = self._default_summary_writer()
-        self.__dict__ = state_dict
+        vars(self).update(state_dict)
 
 
 def check_if_proposal_has_default_x(proposal: Any):

sbi/samplers/vi/vi_divergence_optimizers.py

@@ -327,15 +327,13 @@ def get_loss_stats(self) -> Tuple[Array, Array]:
 
     def update(self, kwargs: Dict):
         """Updates the hyperparameters and scheduler/optimizer kwargs"""
-        # print(kwargs)
-        paras = self.__dict__
         for key, val in kwargs.items():
             if key == "retain_graph":
                 self.retain_graph = val
             if key == "learning_rate":
                 self.learning_rate = val
             if key in self.HYPER_PARAMETERS:
-                paras[key] = val
+                setattr(self, key, val)
 
             if key == "self":
                 posterior = kwargs[key]