Merge pull request #208 from xuwei-k/copy-method-zero-or-one

update `copy` method implementation if field size is 0 or 1

Author: eed3si9n

library/src/main/scala/sbt/contraband/ScalaCodeGen.scala

@@ -492,12 +492,24 @@ class ScalaCodeGen(
 
   private def genCopy(r: ObjectTypeDefinition, intfLang: String) = {
     val allFields = r.fields filter { _.arguments.isEmpty }
-    def genParam(f: FieldDefinition) = s"${bq(f.name)}: ${genRealTpe(f.fieldType, isParam = true, intfLang)} = ${bq(f.name)}"
-    val params = allFields map genParam mkString ", "
-    val constructorCall = allFields map (f => bq(f.name)) mkString ", "
-    s"""private def copy($params): ${r.name} = {
-       |  new ${r.name}($constructorCall)
-       |}""".stripMargin
+    allFields.size match {
+      case 0 =>
+        ""
+      case size =>
+        def genParam(f: FieldDefinition): String = {
+          if (size == 1) {
+            // https://github.com/sbt/contraband/issues/149
+            s"${bq(f.name)}: ${genRealTpe(f.fieldType, isParam = true, intfLang)}"
+          } else {
+            s"${bq(f.name)}: ${genRealTpe(f.fieldType, isParam = true, intfLang)} = ${bq(f.name)}"
+          }
+        }
+        val params = allFields map genParam mkString ", "
+        val constructorCall = allFields map (f => bq(f.name)) mkString ", "
+        s"""private def copy($params): ${r.name} = {
+           |  new ${r.name}($constructorCall)
+           |}""".stripMargin
+    }
   }
 
   private def genWith(r: ObjectTypeDefinition, intfLang: String) = {

library/src/test/scala/GraphQLScalaCodeGenSpec.scala

@@ -52,7 +52,7 @@ object GraphQLScalaCodeGenSpec extends BasicTestSuite with EqualLines {
         |  override def toString: String = {
         |    "TypeExample(" + field + ")"
         |  }
-        |  private def copy(field: Option[java.net.URL] = field): TypeExample = {
+        |  private def copy(field: Option[java.net.URL]): TypeExample = {
         |    new TypeExample(field)
         |  }
         |  def withField(field: Option[java.net.URL]): TypeExample = {
@@ -92,7 +92,7 @@ object GraphQLScalaCodeGenSpec extends BasicTestSuite with EqualLines {
         |  override def toString: String = {
         |    "TypeExample(" + field + ")"
         |  }
-        |  private def copy(field: Option[java.net.URL] = field): TypeExample = {
+        |  private def copy(field: Option[java.net.URL]): TypeExample = {
         |    new TypeExample(field)
         |  }
         |  def withField(field: Option[java.net.URL]): TypeExample = {
@@ -129,7 +129,7 @@ object GraphQLScalaCodeGenSpec extends BasicTestSuite with EqualLines {
         |  override def toString: String = {
         |    "TypeExample(" + field + ")"
         |  }
-        |  private def copy(field: scala.collection.immutable.Map[String, String] = field): TypeExample = {
+        |  private def copy(field: scala.collection.immutable.Map[String, String]): TypeExample = {
         |    new TypeExample(field)
         |  }
         |  def withField(field: scala.collection.immutable.Map[String, String]): TypeExample = {
@@ -163,7 +163,7 @@ object GraphQLScalaCodeGenSpec extends BasicTestSuite with EqualLines {
         |  override def toString: String = {
         |    "Growable(" + field + ")"
         |  }
-        |  private def copy(field: Option[Int] = field): Growable = {
+        |  private def copy(field: Option[Int]): Growable = {
         |    new Growable(field)
         |  }
         |  def withField(field: Option[Int]): Growable = {
@@ -249,7 +249,7 @@ object GraphQLScalaCodeGenSpec extends BasicTestSuite with EqualLines {
         |  override def toString: String = {
         |    "ModifierExample(" + field + ")"
         |  }
-        |  private def copy(field: Int = field): ModifierExample = {
+        |  private def copy(field: Int): ModifierExample = {
         |    new ModifierExample(field)
         |  }
         |  def withField(field: Int): ModifierExample = {

library/src/test/scala/JsonScalaCodeGenSpec.scala

@@ -145,9 +145,6 @@ class JsonScalaCodeGenSpec extends GCodeGenSpec("Scala") {
         |  override def toString: String = {
         |    "ChildRecord()"
         |  }
-        |  private def copy(): ChildRecord = {
-        |    new ChildRecord()
-        |  }
         |}
         |object ChildRecord {
         |  def apply(): ChildRecord = new ChildRecord()
@@ -204,7 +201,7 @@ class JsonScalaCodeGenSpec extends GCodeGenSpec("Scala") {
         |  override def toString: String = {
         |    "simpleRecordExample(" + field + ")"
         |  }
-        |  private def copy(field: java.net.URL = field): simpleRecordExample = {
+        |  private def copy(field: java.net.URL): simpleRecordExample = {
         |    new simpleRecordExample(field)
         |  }
         |  def withField(field: java.net.URL): simpleRecordExample = {
@@ -234,7 +231,7 @@ class JsonScalaCodeGenSpec extends GCodeGenSpec("Scala") {
         |  override def toString: String = {
         |    "growableAddOneField(" + field + ")"
         |  }
-        |  private def copy(field: Int = field): growableAddOneField = {
+        |  private def copy(field: Int): growableAddOneField = {
         |    new growableAddOneField(field)
         |  }
         |  def withField(field: Int): growableAddOneField = {
@@ -342,7 +339,7 @@ object primitiveTypesExample2 {
         |  override def toString: String = {
         |    "modifierExample(" + field + ")"
         |  }
-        |  private def copy(field: Int = field): modifierExample = {
+        |  private def copy(field: Int): modifierExample = {
         |    new modifierExample(field)
         |  }
         |  def withField(field: Int): modifierExample = {

plugin/src/sbt-test/sbt-contraband/simple-new-schema/build.sbt

@@ -1,3 +1,7 @@
 scalaVersion := "3.7.3"
+
+// https://github.com/sbt/contraband/issues/149
+scalacOptions += "-Wunused:all"
+scalacOptions += "-Werror"
 name := "example"
 enablePlugins(ContrabandPlugin, JsonCodecPlugin)