[2.x] Drop the Manifest usage

eed3si9n · eed3si9n · commit 099e7bce628d · 2026-01-14T00:20:23.000-05:00
Manifest doesn't seem to exist in Scala 3.8.0.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -4,8 +4,6 @@ on:
   push:
 
 env:
-  SCALA212: 2.12.*
-  SCALA213: 2.13.*
   SCALA3: 3.*
 
 jobs:
@@ -58,24 +56,15 @@ jobs:
       shell: bash
       run: |
         find **/src/main/contraband-scala -name "*.scala" -delete
-        sbt -v -Dfile.encoding=UTF8 -Dsbt.test.fork=true ++$SCALA212 generateContrabands mimaReportBinaryIssues scalafmtCheckAll headerCheck Test/headerCheck test doc
-        sbt -v -Dfile.encoding=UTF8 -Dsbt.test.fork=false ++$SCALA213 test ++$SCALA3 test
+        sbt -v -Dfile.encoding=UTF8 -Dsbt.test.fork=true generateContrabands mimaReportBinaryIssues scalafmtCheckAll headerCheck Test/headerCheck test doc
         git diff --exit-code # check contrabands
     - name: Build and test (2)
       if: ${{ matrix.jobtype == 2 }}
       shell: bash
       run: |
-        sbt -v -Dfile.encoding=UTF8 -Dsbt.test.fork=true ++$SCALA212 mimaReportBinaryIssues test
-        sbt -v --client ++$SCALA213
-        sbt -v --client test
-        sbt -v --client ++$SCALA3
-        sbt -v --client test
+        sbt -v -Dfile.encoding=UTF8 -Dsbt.test.fork=true mimaReportBinaryIssues test
     - name: Build and test (3)
       if: ${{ matrix.jobtype == 3 }}
       shell: bash
       run: |
-        sbt -v -Dfile.encoding=UTF8 -Dsbt.test.fork=true ++$SCALA212 test
-        sbt -v --client ++$SCALA213
-        sbt -v --client test
-        sbt -v --client ++$SCALA3
         sbt -v --client test
diff --git a/build.sbt b/build.sbt
@@ -45,9 +45,9 @@ ThisBuild / publishTo := {
 }
 
 def commonSettings: Seq[Setting[?]] = Seq(
-  scalaVersion := scala212,
+  scalaVersion := scala3,
   compile / javacOptions ++= Seq("-Xlint", "-Xlint:-serial"),
-  crossScalaVersions := Seq(scala212, scala213, scala3),
+  crossScalaVersions := Seq(scala3),
   headerLicense := (ThisBuild / headerLicense).value,
 )
 
@@ -91,79 +91,9 @@ val io = (project in file("io"))
     mimaPreviousArtifacts := (CrossVersion partialVersion scalaVersion.value match {
       case Some((2, n)) if n >= 13 => Set.empty
       case _                       =>
-        Set(
-          "1.0.0",
-          "1.0.1",
-          "1.0.2",
-          "1.1.0",
-          "1.1.1",
-          "1.1.2",
-          "1.1.3",
-          "1.1.4",
-          "1.2.0",
-          "1.3.0",
-          "1.4.0",
-          "1.5.0",
-          "1.6.0",
-          "1.7.0",
-          "1.8.0",
-          "1.9.0",
-          "1.10.0",
-        ) map (version => organization.value %% moduleName.value % version)
+        Set().map((version: String) => organization.value %% moduleName.value % version)
     }),
     mimaBinaryIssueFilters ++= Seq(
-      exclude[FinalClassProblem]("sbt.internal.io.MacJNA$TimeBuf"),
-      // MiMa doesn't treat effectively final members as final
-      // WORKAROUND typesafehub/migration-manager#162
-      exclude[FinalMethodProblem]("sbt.io.SimpleFilter.accept"),
-      exclude[FinalMethodProblem]("sbt.io.SimpleFileFilter.accept"),
-      // MiMa doesn't understand private inner classes?
-      // method this(sbt.io.PollingWatchService,sbt.io.PollingWatchService#PollingThread,java.nio.file.Watchable,java.util.List)Unit in class sbt.io.PollingWatchService#PollingWatchKey does not have a correspondent in current version
-      exclude[DirectMissingMethodProblem]("sbt.io.PollingWatchService#PollingWatchKey.this"),
-      exclude[IncompatibleMethTypeProblem]("sbt.io.PollingWatchService#PollingWatchKey.this"),
-      // This is a private class
-      exclude[DirectMissingMethodProblem]("sbt.io.PollingWatchService#PollingWatchKey.events"),
-      exclude[DirectMissingMethodProblem]("sbt.io.PollingWatchService#PollingWatchKey.offer"),
-      // This is a private class
-      exclude[DirectMissingMethodProblem]("sbt.io.PollingWatchService#PollingThread.events"),
-      exclude[DirectMissingMethodProblem]("sbt.io.PollingWatchService#PollingThread.initDone"),
-      exclude[DirectMissingMethodProblem]("sbt.io.PollingWatchService#PollingThread.initDone_="),
-      exclude[DirectMissingMethodProblem](
-        "sbt.io.PollingWatchService#PollingThread.keysWithEvents"
-      ),
-      exclude[DirectMissingMethodProblem]("sbt.io.PollingWatchService#PollingThread.getFileTimes"),
-      // moved JavaMilli to sbt.io
-      exclude[MissingClassProblem]("sbt.internal.io.JavaMilli$"),
-      exclude[MissingClassProblem]("sbt.internal.io.JavaMilli"),
-      // These are private classes
-      exclude[MissingClassProblem]("sbt.internal.io.*"),
-      // Replaced non-standard __xstat64() with conformant stat() calls
-      exclude[DirectMissingMethodProblem]("sbt.internal.io.Linux32.*"),
-      exclude[ReversedMissingMethodProblem]("sbt.internal.io.Linux32.*"),
-      exclude[DirectMissingMethodProblem]("sbt.internal.io.Linux64.*"),
-      exclude[ReversedMissingMethodProblem]("sbt.internal.io.Linux64.*"),
-      // protected[this]
-      exclude[DirectMissingMethodProblem]("sbt.io.CopyOptions.copy*"),
-      // private class
-      exclude[MissingClassProblem]("sbt.io.Event"),
-      exclude[MissingClassProblem]("sbt.io.Event$"),
-      exclude[MissingClassProblem]("sbt.io.MacOSXWatchKey"),
-      exclude[MissingClassProblem]("sbt.io.PollingWatchEvent"),
-      exclude[MissingClassProblem]("sbt.io.PollingWatchService$PollingWatchKey"),
-      exclude[MissingClassProblem]("sbt.io.PollingWatchService$PollingThread"),
-      exclude[MissingClassProblem]("sbt.io.PollingWatchService$Overflow$"),
-      // private internal classes whose functionality has been replaced
-      exclude[MissingClassProblem]("sbt.internal.io.EventMonitor*"),
-      exclude[DirectMissingMethodProblem]("sbt.internal.io.EventMonitor.legacy"),
-      exclude[DirectMissingMethodProblem]("sbt.internal.io.EventMonitor.applyImpl"),
-      // private classes that have been removed
-      exclude[MissingClassProblem]("sbt.internal.io.Alternatives$"),
-      exclude[MissingClassProblem]("sbt.internal.io.Alternatives"),
-      exclude[DirectMissingMethodProblem]("sbt.io.NothingFilter.unary_-"),
-      exclude[DirectMissingMethodProblem]("sbt.io.AllPassFilter.unary_-"),
-      exclude[IncompatibleSignatureProblem]("sbt.io.PollingWatchService.pollEvents"),
-      exclude[IncompatibleSignatureProblem]("sbt.io.WatchService#WatchServiceAdapter.pollEvents"),
-      exclude[IncompatibleSignatureProblem]("sbt.io.WatchService.pollEvents"),
     ),
     BuildInfoPlugin.buildInfoDefaultSettings, // avoids BuildInfo generated in Compile scope
     addBuildInfoToConfig(Test),
diff --git a/io/src/main/scala/sbt/io/IO.scala b/io/src/main/scala/sbt/io/IO.scala
@@ -31,7 +31,7 @@ import scala.collection.JavaConverters._
 import scala.collection.immutable
 import scala.collection.immutable.TreeSet
 import scala.collection.mutable.{ HashMap, HashSet }
-import scala.reflect.{ Manifest => SManifest }
+import scala.reflect.ClassTag
 import scala.util.control.Exception._
 import scala.util.control.NonFatal
 
@@ -79,8 +79,8 @@ object IO {
    * If the location cannot be determined, an error is generated.
    * Note that for JDK 11 onwards, a module will return a jrt path.
    */
-  def classLocationPath[A](implicit mf: SManifest[A]): NioPath =
-    classLocationPath(mf.runtimeClass)
+  def classLocationPath[A: ClassTag]: NioPath =
+    classLocationPath(implicitly[ClassTag[A]].runtimeClass)
 
   /**
    * Returns the directory, Java module, or the JAR containing the class file `cl`.
@@ -97,31 +97,8 @@ object IO {
    * If the location cannot be determined or it is not a file, an error is generated.
    * Note that for JDK 11 onwards, the returned module path cannot be expressed as `File`, so it will return `None`.
    */
-  def classLocationFileOption[A](implicit mf: SManifest[A]): Option[File] =
-    classLocationFileOption(mf.runtimeClass)
-
-  /**
-   * Returns the directory, Java module, or the JAR file containing the class file `cl`.
-   * If the location cannot be determined or it is not a file, an error is generated.
-   * Note that for JDK 11 onwards, the returned module path cannot be expressed as `File`.
-   */
-  @deprecated(
-    "classLocationFile may not work on JDK 11. Use classfileLocation, classLocationFileOption, or classLocationPath instead.",
-    "1.3.0"
-  )
-  def classLocationFile(cl: Class[?]): File =
-    classLocationFileOption(cl).getOrElse(sys.error(s"Unable to create File from $cl"))
-
-  /**
-   * Returns the directory, Java module, or the JAR file containing the class file for type `T` (as determined by an implicit Manifest).
-   * If the location cannot be determined, an error is generated.
-   * Note that for JDK 11 onwards, the returned module path cannot be expressed as `File`.
-   */
-  @deprecated(
-    "classLocationFile may not work on JDK 11. Use classfileLocation, classLocationFileOption, or classLocationPath instead.",
-    "1.3.0"
-  )
-  def classLocationFile[T](implicit mf: SManifest[T]): File = classLocationFile(mf.runtimeClass)
+  def classLocationFileOption[A: ClassTag]: Option[File] =
+    classLocationFileOption(implicitly[ClassTag[A]].runtimeClass)
 
   /**
    * Returns the URL to the directory, Java module, or the JAR file containing the class file `cl`.
@@ -174,14 +151,15 @@ object IO {
    * If the location cannot be determined or it is not a file, an error is generated.
    * Note that for JDK 11 onwards, a module will return a jrt path.
    */
-  def classLocation[A](implicit mf: SManifest[A]): URL =
-    classLocation(mf.runtimeClass)
+  def classLocation[A: ClassTag]: URL =
+    classLocation(implicitly[ClassTag[A]].runtimeClass)
 
   /**
    * Returns a URL for the classfile containing the given class file for type `T` (as determined by an implicit Manifest).
    * If the location cannot be determined, an error is generated.
    */
-  def classfileLocation[T](implicit mf: SManifest[T]): URL = classfileLocation(mf.runtimeClass)
+  def classfileLocation[T: ClassTag]: URL =
+    classfileLocation(implicitly[ClassTag[T]].runtimeClass)
 
   /**
    * Returns a URL for the classfile containing the given class
diff --git a/io/src/main/scala/sbt/io/Using.scala b/io/src/main/scala/sbt/io/Using.scala
@@ -32,29 +32,29 @@ import java.util.jar.{ JarFile, JarInputStream, JarOutputStream }
 import java.util.zip.{ GZIPInputStream, _ }
 
 import sbt.internal.io.ErrorHandling.translate
+import scala.reflect.ClassTag
 
-abstract class Using[Source, T] {
-  protected def open(src: Source): T
-  def apply[R](src: Source)(f: T => R): R = {
+abstract class Using[Source, A1] {
+  protected def open(src: Source): A1
+  def apply[R](src: Source)(f: A1 => R): R = {
     val resource = open(src)
     try {
       f(resource)
     } finally {
       close(resource)
     }
   }
-  protected def close(out: T): Unit
+  protected def close(out: A1): Unit
 }
 
-import scala.reflect.{ Manifest => SManifest }
-private[sbt] abstract class WrapUsing[Source, T](implicit
-    srcMf: SManifest[Source],
-    targetMf: SManifest[T]
-) extends Using[Source, T] {
-  protected def label[S](m: SManifest[S]) = m.runtimeClass.getSimpleName
+private[sbt] abstract class WrapUsing[Source: ClassTag, T: ClassTag] extends Using[Source, T] {
+  protected def label[S: ClassTag]: String =
+    implicitly[ClassTag[S]].runtimeClass.getSimpleName
   protected def openImpl(source: Source): T
   protected final def open(source: Source): T =
-    translate("Error wrapping " + label(srcMf) + " in " + label(targetMf) + ": ")(openImpl(source))
+    translate(s"Error wrapping ${label[Source]} in ${label[T]}: ")(
+      openImpl(source)
+    )
 }
 private[sbt] trait OpenFile[T] extends Using[File, T] {
   protected def openImpl(file: File): T
@@ -69,16 +69,10 @@ private[sbt] trait OpenFile[T] extends Using[File, T] {
 }
 
 object Using {
-  def wrap[Source, T <: AutoCloseable](openF: Source => T)(implicit
-      srcMf: SManifest[Source],
-      targetMf: SManifest[T]
-  ): Using[Source, T] =
+  def wrap[Source: ClassTag, T <: AutoCloseable: ClassTag](openF: Source => T): Using[Source, T] =
     wrap(openF, closeCloseable)
 
-  def wrap[Source, T](openF: Source => T, closeF: T => Unit)(implicit
-      srcMf: SManifest[Source],
-      targetMf: SManifest[T]
-  ): Using[Source, T] =
+  def wrap[Source: ClassTag, T: ClassTag](openF: Source => T, closeF: T => Unit): Using[Source, T] =
     new WrapUsing[Source, T] {
       def openImpl(source: Source) = openF(source)
       def close(t: T) = closeF(t)
diff --git a/io/src/test/scala/sbt/io/FileUtilitiesSpecification.scala b/io/src/test/scala/sbt/io/FileUtilitiesSpecification.scala
@@ -36,7 +36,7 @@ object WriteContentSpecification extends Properties("Write content") {
 
   private def largeUnzip() = {
     testUnzip[Product]
-    testUnzip[scala.tools.nsc.Global]
+    testUnzip[dotty.tools.backend.jvm.BTypes]
     true
   }
 
diff --git a/project/Dependencies.scala b/project/Dependencies.scala
@@ -4,11 +4,11 @@ import Keys._
 object Dependencies {
   val scala212 = "2.12.21"
   val scala213 = "2.13.18"
-  val scala3 = "3.3.7"
+  val scala3 = "3.7.4"
 
   val scalaCompiler = Def.setting {
-    val v = if (scalaBinaryVersion.value == "3") scala213 else scalaVersion.value
-    "org.scala-lang" % "scala-compiler" % v
+    val v = scalaVersion.value
+    "org.scala-lang" %% "scala3-compiler" % v
   }
 
   val scalaVerify = "com.eed3si9n.verify" %% "verify" % "1.0.0"

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ object WriteContentSpecification extends Properties("Write content") {`
`36`	`36`
`37`	`37`	`private def largeUnzip() = {`
`38`	`38`	`testUnzip[Product]`
`39`		`- testUnzip[scala.tools.nsc.Global]`
	`39`	`+ testUnzip[dotty.tools.backend.jvm.BTypes]`
`40`	`40`	`true`
`41`	`41`	`}`
`42`	`42`