Merge pull request #2710 from tgodzik/log-if-fails

improvement: Log if visiting file fails

Author: tgodzik

frontend/src/main/scala/bloop/engine/tasks/compilation/CompileBundle.scala

@@ -193,7 +193,8 @@ object CompileBundle {
             sourceGeneratorCache.update(_, logger, options),
             20,
             cancelCompilation,
-            ioScheduler
+            ioScheduler,
+            logger
           )
           .map(res => res.map(_.sortBy(_.source.id())))
           .executeOn(ioScheduler)

frontend/src/main/scala/bloop/io/SourceHasher.scala

@@ -25,6 +25,7 @@ import monix.reactive.Consumer
 import monix.reactive.MulticastStrategy
 import monix.reactive.Observable
 import sbt.internal.inc.PlainVirtualFileConverter
+import bloop.logging.Logger
 
 object SourceHasher {
   private final val sourceMatcher =
@@ -58,7 +59,8 @@ object SourceHasher {
       updateGenerator: SourceGenerator => Task[List[AbsolutePath]],
       parallelUnits: Int,
       cancelCompilation: Promise[Unit],
-      scheduler: Scheduler
+      scheduler: Scheduler,
+      logger: Logger
   ): Task[Either[Unit, List[HashedSource]]] = {
     val isCancelled = AtomicBoolean(false)
     val sourceFilesAndDirectories = project.sources.distinct
@@ -80,8 +82,10 @@ object SourceHasher {
       def visitFileFailed(
           t: Path,
           e: IOException
-      ): FileVisitResult = FileVisitResult.CONTINUE
-
+      ): FileVisitResult = {
+        logger.error(s"Failed to visit file $t: ${e.getMessage}", e)
+        FileVisitResult.CONTINUE
+      }
       def preVisitDirectory(
           directory: Path,
           attributes: BasicFileAttributes
@@ -103,7 +107,7 @@ object SourceHasher {
       val discovery = fileVisitor(matchSourceFile)
       val opts = java.util.EnumSet.of(FileVisitOption.FOLLOW_LINKS)
       sourceFilesAndDirectories.foreach { sourcePath =>
-        if (visitedDirs.contains(sourcePath.underlying)) ()
+        if (visitedDirs.contains(sourcePath.underlying) || !sourcePath.exists) ()
         else if (isCancelled.get) ()
         else {
           Files.walkFileTree(sourcePath.underlying, opts, Int.MaxValue, discovery)

frontend/src/test/scala/bloop/io/SourceHasherSpec.scala

@@ -44,7 +44,8 @@ object SourceHasherSpec extends bloop.testing.BaseSuite {
           state.state.sourceGeneratorCache.update(_, logger, state.state.commonOptions),
           2,
           cancelPromise,
-          ioScheduler
+          ioScheduler,
+          logger
         )
       val running = sourceHashesTask.runAsync(ioScheduler)
 
@@ -61,7 +62,8 @@ object SourceHasherSpec extends bloop.testing.BaseSuite {
           state.state.sourceGeneratorCache.update(_, logger, state.state.commonOptions),
           2,
           cancelPromise2,
-          ioScheduler
+          ioScheduler,
+          logger
         )
       val running2 = sourceHashesTask2.runAsync(ioScheduler)
       val uncancelledResult = Await.result(running2, FiniteDuration(20, "s"))

frontend/src/test/scala/bloop/io/SourcesGlobsSpec.scala

@@ -53,7 +53,8 @@ object SourcesGlobsSpec extends bloop.testing.BaseSuite {
           state.sourceGeneratorCache.update(_, logger, state.commonOptions),
           1,
           Promise[Unit](),
-          ioScheduler
+          ioScheduler,
+          logger
         )
         val Right(result) = TestUtil.await(10, TimeUnit.SECONDS)(hashedSources)
         val obtainedFilenames = result