rmove currently not needed optimizations

Author: tgodzik

modules/infra/src/main/resources/reference.conf

@@ -13,21 +13,6 @@ scaladex {
     name = ${?POSTGRESQL_DATABASE}
     port = 5432
     url = "jdbc:postgresql://"${scaladex.database.user}":"${scaladex.database.password}"@localhost:"${scaladex.database.port}"/"${scaladex.database.name}
-    
-    pool {
-      maximum-pool-size = 20
-      maximum-pool-size = ${?DB_POOL_MAX_SIZE}
-      minimum-idle = 5
-      minimum-idle = ${?DB_POOL_MIN_IDLE}
-      connection-timeout-ms = 30000
-      connection-timeout-ms = ${?DB_CONNECTION_TIMEOUT_MS}
-      idle-timeout-ms = 600000
-      idle-timeout-ms = ${?DB_IDLE_TIMEOUT_MS}
-      max-lifetime-ms = 1800000
-      max-lifetime-ms = ${?DB_MAX_LIFETIME_MS}
-      leak-detection-threshold-ms = 60000
-      leak-detection-threshold-ms = ${?DB_LEAK_DETECTION_MS}
-    }
   }
   github {
     # follow this tutorial to create your token https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token

modules/infra/src/main/scala/scaladex/infra/config/DatabasePoolConfig.scala

@@ -2,7 +2,6 @@ package scaladex.infra.sql
 
 import scala.concurrent.ExecutionContext
 
-import scaladex.infra.config.DatabasePoolConfig
 import scaladex.infra.config.PostgreSQLConfig
 
 import cats.effect.*
@@ -29,20 +28,11 @@ object DoobieUtils:
       .load()
 
   def getHikariDataSource(conf: PostgreSQLConfig): HikariDataSource =
-    getHikariDataSource(conf, DatabasePoolConfig.load().getOrElse(DatabasePoolConfig.default))
-
-  def getHikariDataSource(conf: PostgreSQLConfig, poolConfig: DatabasePoolConfig): HikariDataSource =
     val config: HikariConfig = new HikariConfig()
     config.setDriverClassName(conf.driver)
     config.setJdbcUrl(conf.url)
     config.setUsername(conf.user)
     config.setPassword(conf.pass.decode)
-    config.setMaximumPoolSize(poolConfig.maximumPoolSize)
-    config.setMinimumIdle(poolConfig.minimumIdle)
-    config.setConnectionTimeout(poolConfig.connectionTimeoutMs)
-    config.setIdleTimeout(poolConfig.idleTimeoutMs)
-    config.setMaxLifetime(poolConfig.maxLifetimeMs)
-    config.setLeakDetectionThreshold(poolConfig.leakDetectionThresholdMs)
     new HikariDataSource(config)
   end getHikariDataSource
 

modules/infra/src/main/scala/scaladex/infra/sql/DoobieUtils.scala

@@ -82,6 +82,7 @@ class MavenCentralService(
       yield result
 
     loop(0, 0).map(n => s"Inserted $n missing poms")
+  end findMissing
 
   private def findAndIndexMissingArtifacts(
       groupId: GroupId,
@@ -113,6 +114,7 @@ class MavenCentralService(
           else Future.successful(next)
       yield result
     loop(0, Set.empty)
+  end loadKnownRefs
 
   /** Process items in pages, with a short delay between full pages. */
   private def processPages[A](items: Seq[A], pageSize: Int)(process: Seq[A] => Future[Int]): Future[Int] =
@@ -127,7 +129,9 @@ class MavenCentralService(
             if batch.size == pageSize then delay(pageDelay).flatMap(_ => loop(page + 1, next))
             else Future.successful(next)
         yield result
+    end loop
     loop(0, 0)
+  end processPages
 
   private def delay(duration: FiniteDuration): Future[Unit] =
     after(duration, system.scheduler)(Future.successful(()))