improvement: Try to fix an issue wiht performance

Author: tgodzik

modules/infra/src/main/resources/migrations/V28__add_performance_indexes.sql

@@ -0,0 +1,18 @@
+-- Add indexes to improve query performance and reduce connection pool pressure
+
+-- Index for is_latest_version queries (used on every page header)
+CREATE INDEX IF NOT EXISTS artifact_latest_version_idx
+    ON artifacts (organization, repository)
+    WHERE is_latest_version = true;
+
+-- Index for Maven coordinate lookups (group_id, artifact_id)
+CREATE INDEX IF NOT EXISTS artifact_maven_coords_idx
+    ON artifacts (group_id, artifact_id);
+
+-- Index for dependency lookups by source
+CREATE INDEX IF NOT EXISTS artifact_dep_source_idx
+    ON artifact_dependencies (source_group_id, source_artifact_id, source_version);
+
+-- Index for reverse dependency lookups by target
+CREATE INDEX IF NOT EXISTS artifact_dep_target_idx
+    ON artifact_dependencies (target_group_id, target_artifact_id, target_version);

modules/infra/src/main/resources/reference.conf

@@ -13,6 +13,21 @@ scaladex {
     name = ${?POSTGRESQL_DATABASE}
     port = 5432
     url = "jdbc:postgresql://"${scaladex.database.user}":"${scaladex.database.password}"@localhost:"${scaladex.database.port}"/"${scaladex.database.name}
+    
+    pool {
+      maximum-pool-size = 20
+      maximum-pool-size = ${?DB_POOL_MAX_SIZE}
+      minimum-idle = 5
+      minimum-idle = ${?DB_POOL_MIN_IDLE}
+      connection-timeout-ms = 30000
+      connection-timeout-ms = ${?DB_CONNECTION_TIMEOUT_MS}
+      idle-timeout-ms = 600000
+      idle-timeout-ms = ${?DB_IDLE_TIMEOUT_MS}
+      max-lifetime-ms = 1800000
+      max-lifetime-ms = ${?DB_MAX_LIFETIME_MS}
+      leak-detection-threshold-ms = 60000
+      leak-detection-threshold-ms = ${?DB_LEAK_DETECTION_MS}
+    }
   }
   github {
     # follow this tutorial to create your token https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token

modules/infra/src/main/scala/scaladex/infra/config/DatabasePoolConfig.scala

@@ -0,0 +1,42 @@
+package scaladex.infra.config
+
+import scala.util.Try
+
+import com.typesafe.config.Config
+import com.typesafe.config.ConfigFactory
+
+final case class DatabasePoolConfig(
+    maximumPoolSize: Int,
+    minimumIdle: Int,
+    connectionTimeoutMs: Long,
+    idleTimeoutMs: Long,
+    maxLifetimeMs: Long,
+    leakDetectionThresholdMs: Long
+)
+
+object DatabasePoolConfig:
+  val default: DatabasePoolConfig = DatabasePoolConfig(
+    maximumPoolSize = 20,
+    minimumIdle = 5,
+    connectionTimeoutMs = 30000,
+    idleTimeoutMs = 600000,
+    maxLifetimeMs = 1800000,
+    leakDetectionThresholdMs = 60000
+  )
+
+  def load(): Try[DatabasePoolConfig] =
+    val config = ConfigFactory.load()
+    from(config)
+
+  def from(config: Config): Try[DatabasePoolConfig] = Try {
+    val poolConfig = config.getConfig("scaladex.database.pool")
+    DatabasePoolConfig(
+      maximumPoolSize = poolConfig.getInt("maximum-pool-size"),
+      minimumIdle = poolConfig.getInt("minimum-idle"),
+      connectionTimeoutMs = poolConfig.getLong("connection-timeout-ms"),
+      idleTimeoutMs = poolConfig.getLong("idle-timeout-ms"),
+      maxLifetimeMs = poolConfig.getLong("max-lifetime-ms"),
+      leakDetectionThresholdMs = poolConfig.getLong("leak-detection-threshold-ms")
+    )
+  }
+end DatabasePoolConfig

modules/infra/src/main/scala/scaladex/infra/sql/DoobieUtils.scala

@@ -2,6 +2,7 @@ package scaladex.infra.sql
 
 import scala.concurrent.ExecutionContext
 
+import scaladex.infra.config.DatabasePoolConfig
 import scaladex.infra.config.PostgreSQLConfig
 
 import cats.effect.*
@@ -28,11 +29,20 @@ object DoobieUtils:
       .load()
 
   def getHikariDataSource(conf: PostgreSQLConfig): HikariDataSource =
+    getHikariDataSource(conf, DatabasePoolConfig.load().getOrElse(DatabasePoolConfig.default))
+
+  def getHikariDataSource(conf: PostgreSQLConfig, poolConfig: DatabasePoolConfig): HikariDataSource =
     val config: HikariConfig = new HikariConfig()
     config.setDriverClassName(conf.driver)
     config.setJdbcUrl(conf.url)
     config.setUsername(conf.user)
     config.setPassword(conf.pass.decode)
+    config.setMaximumPoolSize(poolConfig.maximumPoolSize)
+    config.setMinimumIdle(poolConfig.minimumIdle)
+    config.setConnectionTimeout(poolConfig.connectionTimeoutMs)
+    config.setIdleTimeout(poolConfig.idleTimeoutMs)
+    config.setMaxLifetime(poolConfig.maxLifetimeMs)
+    config.setLeakDetectionThreshold(poolConfig.leakDetectionThresholdMs)
     new HikariDataSource(config)
 
   def transactor(datasource: HikariDataSource): Resource[IO, HikariTransactor[IO]] =

modules/server/src/main/scala/scaladex/server/Server.scala

@@ -184,6 +184,18 @@ object Server extends LazyLogging:
           complete(StatusCodes.InternalServerError, notfound(config.env, None))
         }
     }
-    handleExceptions(exceptionHandler)(route)
+
+    val loggingDirective =
+      if config.requestLogging.enabled then
+        if config.requestLogging.slowOnly then
+          RequestLogging.logSlowRequests(config.requestLogging.slowThresholdMs)
+        else
+          RequestLogging.logRequests
+      else
+        pass
+
+    loggingDirective {
+      handleExceptions(exceptionHandler)(route)
+    }
   end configureRoutes
 end Server

modules/server/src/main/scala/scaladex/server/route/ProjectPages.scala

@@ -85,7 +85,7 @@ class ProjectPages(
           artifactsParams { params =>
             getProjectOrRedirect(ref, user) { project =>
               val artifactsF = database.getProjectArtifacts(ref, artifactName, params.stableOnly)
-              val headerF = projectService.getHeader(project).map(_.get)
+              val headerF = projectService.getHeader(project)
               for artifacts <- artifactsF; header <- headerF yield
                 val binaryVersions = artifacts
                   .map(_.binaryVersion)
@@ -314,10 +314,13 @@ class ProjectPages(
 
   private def getBadges(ref: Project.Reference, user: Option[UserState]): Route =
     getProjectOrRedirect(ref, user) { project =>
-      for header <- projectService.getHeader(project).map(_.get) yield
-        val artifact = header.getDefaultArtifact(None, None)
-        val page = html.badges(env, user, project, header, artifact)
-        complete(StatusCodes.OK, page)
+      for header <- projectService.getHeader(project) yield
+        header.flatMap(_.getDefaultArtifact(None, None)) match
+          case Some(artifact) =>
+            val page = html.badges(env, user, project, header, artifact)
+            complete(StatusCodes.OK, page)
+          case None =>
+            complete(StatusCodes.NotFound)
     }
 
   private val editForm: Directive1[Project.Settings] =

modules/template/src/main/twirl/scaladex/view/project/badges.scala.html

@@ -13,12 +13,12 @@
   env: Env,
   user: Option[UserState],
   project: Project,
-  header: ProjectHeader,
+  header: Option[ProjectHeader],
   artifact: Artifact
 )
 @main(env, title = project.repository.value, user, extraMeta = project.twitterCard.toHeadMeta, extraMetaProperty = project.ogp.toHeadMetaProperty) {
   <main id="container-project">
-    @headproject(env, user, project, Some(header), ProjectTab.Badges)
+    @headproject(env, user, project, header, ProjectTab.Badges)
     <div class="container">
       <div class="content-project box project-badges">
         <section class="badge-section" id="latest">
@@ -27,7 +27,7 @@ <h2>Latest version</h2>
           <pre aria-label="Badge markdown" id="badge-markdown">[![@artifact.name Scala version support](@artifact.latestBadgeUrl(env))](@artifact.fullHttpUrl(env))</pre>
           <button class="btn btn-primary btn-copy pull-right" data-clipboard-target="badge-markdown">Copy Markdown</button>
         </section>
-        @header.platforms(artifact.name).map { platform =>
+        @header.toSeq.flatMap(_.platforms(artifact.name)).map { platform =>
           <section class="badge-section" id="@platform">
             <h2>@platform badge</h2>
             <img src="@artifact.badgeUrl(env, Some(platform))" />

modules/template/src/main/twirl/scaladex/view/project/versions.scala.html

@@ -15,7 +15,7 @@
     env: Env,
     user: Option[UserState],
     project: Project,
-    header: ProjectHeader,
+    header: Option[ProjectHeader],
     artifactName: Artifact.Name,
     allBinaryVersions: Seq[BinaryVersion],
     artifactByVersions: SortedMap[(Instant, Version), Seq[Artifact]],
@@ -24,7 +24,7 @@
 
 @main(env, title = project.repository.toString, user) {
   <main id="container-project">
-    @headproject(env, user, project, Some(header), ProjectTab.Versions)
+    @headproject(env, user, project, header, ProjectTab.Versions)
     <div class="container">
       <div class="content-project versions box" data-organization="@project.reference.organization"
       data-repository="@project.reference.repository">
@@ -34,7 +34,7 @@ <h2>
           <select class="selectpicker" title="Other Artifacts"
             data-style="btn-default" data-selected-text-format="static" 
             onchange="window.location=this.value">
-            @for(name <- header.allArtifactNames) {
+            @for(name <- header.map(_.allArtifactNames).getOrElse(Seq.empty)) {
               <option value="@versionsUri(project.reference, name, params)" @if(name == artifactName) {selected}>
                 @name
               </option>