RemoveUnused with -Ywarn-unused:<option>

[bmarker]

RemoveUnused and the removeUnused option for OrganizedImports don't seem to recognize the -Ywarn-unused:imports and similar options.

I had these from tpolecat:

  "-Ywarn-unused:implicits",           // Warn if an implicit parameter is unused.
  "-Ywarn-unused:imports",             // Warn if an import selector is not referenced.
  "-Ywarn-unused:locals",              // Warn if a local definition is unused.
  "-Ywarn-unused:params",              // Warn if a value parameter is unused.
  "-Ywarn-unused:patvars",             // Warn if a variable bound in a pattern is unused.
  "-Ywarn-unused:privates",            // Warn if a private member is unused.

But I still had to add -Ywarn-unused to get removing unused imports working.

I don't know if there's a check for the scalacOptions that could be adjusted or if it's more about how the rules work.

[bmarker]

It looks like it's looking for a prefix to me :

scalafix/scalafix-rules/src/main/scala/scalafix/internal/rule/RemoveUnused.scala

Line 32 in 691a4f0

private def warnUnusedPrefix = List("-Wunused", "-Ywarn-unused")

I also don't get a warning that the option is not set. However, nothing gets auto-fixed either.

[bmarker]

I'm using -Xfatal-warnings and -Wconf:cat=unused:info. I wonder if it's the -Wconf that's specific to unused and not unused:imports.

[bjaglin]

I'm using -Xfatal-warnings and -Wconf:cat=unused:info. I wonder if it's the -Wconf that's specific to unused and not unused:imports.

Could you provide a repro?

[bjaglin]

Any update @bmarker ? Thanks!

[bmarker]

I'm sorry but this is part of an enterprise project with other plugins and I do not have a smaller reproduction case.

[bmarker]

IIRC, I did try a sandbox way back and could not reproduce this with a smaller build.sbt (and no other plugins).

With this in the build.sbt, an unused import (added intentionally to test this) is removed. Without these lines in the build.sbt, the import is not removed:

tpolecatScalacOptions ~= { opts => opts - ScalacOptions.privateWarnUnused }
tpolecatScalacOptions += ScalacOptions.privateWarnOption("unused")
tpolecatScalacOptions += ScalacOptions.warnOption("conf:cat=unused:info")

I forget how to view the final scalacOptions after all the plugins etc.

[bmarker]

From the sbt console:

λ print scalacOptions
* -Ypartial-unification
* -deprecation
* -feature
* -unchecked
* -language:existentials
* -language:experimental.macros
* -language:higherKinds
* -language:implicitConversions
* -Xlint:adapted-args
* -Xlint:by-name-right-associative
* -Xlint:constant
* -Xlint:delayedinit-select
* -Xlint:deprecation
* -Xlint:doc-detached
* -Xlint:inaccessible
* -Xlint:infer-any
* -Xlint:missing-interpolator
* -Xlint:nullary-override
* -Xlint:nullary-unit
* -Xlint:option-implicit
* -Xlint:package-object-classes
* -Xlint:poly-implicit-overload
* -Xlint:private-shadow
* -Xlint:stars-align
* -Xlint:type-parameter-shadow
* -Xlint:unsound-match
* -Yno-adapted-args
* -Ywarn-dead-code
* -Ywarn-extra-implicit
* -Ywarn-nullary-override
* -Ywarn-nullary-unit
* -Ywarn-numeric-widen
* -Ywarn-value-discard
* -Ywarn-unused:implicits
* -Ywarn-unused:imports
* -Ywarn-unused:locals
* -Ywarn-unused:params
* -Ywarn-unused:patvars
* -Ywarn-unused:privates
* -Ywarn-unused:nowarn
* -Xfatal-warnings
* -Ywarn-unused
* -Wconf:cat=unused:info
* -P:wartremover:traverser:org.wartremover.warts.AsInstanceOf
* -P:wartremover:traverser:org.wartremover.warts.EitherProjectionPartial
* -P:wartremover:traverser:org.wartremover.warts.IsInstanceOf
* -P:wartremover:traverser:org.wartremover.warts.Null
* -P:wartremover:traverser:org.wartremover.warts.OptionPartial
* -P:wartremover:traverser:org.wartremover.warts.Product
* -P:wartremover:traverser:org.wartremover.warts.Return
* -P:wartremover:traverser:org.wartremover.warts.Serializable
* -P:wartremover:traverser:org.wartremover.warts.StringPlusAny
* -P:wartremover:traverser:org.wartremover.warts.Throw
* -P:wartremover:traverser:org.wartremover.warts.TripleQuestionMark
* -P:wartremover:traverser:org.wartremover.warts.TryPartial
* -encoding
* UTF-8
* -deprecation
* -explaintypes
* -unchecked
* -feature
* -language:_
* -language:experimental.macros
* -Ypartial-unification
* -Ywarn-adapted-args
* -Ywarn-dead-code
* -Ywarn-inaccessible
* -Ywarn-infer-any
* -Ywarn-nullary-override
* -Ywarn-nullary-unit
* -Ywarn-numeric-widen
* -Ywarn-unused:implicits
* -Ywarn-unused:imports
* -Ywarn-unused:locals
* -Ywarn-unused:params
* -Ywarn-unused:patvars
* -Ywarn-unused:privates
* -Ywarn-value-discard
* -Xlint:adapted-args
* -Xlint:by-name-right-associative
* -Xlint:constant
* -Xlint:delayedinit-select
* -Xlint:doc-detached
* -Xlint:inaccessible
* -Xlint:infer-any
* -Xlint:missing-interpolator
* -Xlint:nullary-override
* -Xlint:nullary-unit
* -Xlint:option-implicit
* -Xlint:package-object-classes
* -Xlint:poly-implicit-overload
* -Xlint:private-shadow
* -Xlint:stars-align
* -Xlint:type-parameter-shadow
* -Xlint:unsound-match
* -Xfuture
* -P:splain:all
* -target:jvm-1.8
* -Ywarn-extra-implicit
* -Ywarn-unused:implicits
* -Ywarn-unused:imports
* -Ywarn-unused:locals
* -Ywarn-unused:params
* -Ywarn-unused:patvars
* -Ywarn-unused:privates

I thought there was something not-quite-right about that though. Like it's the global values but not necessarily the values for the compile task.

[bjaglin]

OK, thanks for the details, it does seem like conflicts with sbt-toplecat or another plugin.

Could you send over the output of show Compile / compile / scalacOptions with and without your workaround?