Skip to content

jsdom 27.0.0 changes method name (sendTo -> forwardTo) #506

Description

@raquo

Getting this when I tried to bump jsdom to 27.0.1:

sbt:Laminar> test
...laminar/target/scalajs-bundler-jsdom/codeWithJSDOMContext.js:9
      .sendTo(console, { omitJSDOMErrors: true });

relevant jsdom changelog

relevant scalajs-bundler code

Currently we do:

var virtualConsole = new jsdom.VirtualConsole()
  .sendTo(console, { omitJSDOMErrors: true });

I haven't tested this, but I guess we should do something like this instead:

var virtualConsoleObj = new jsdom.VirtualConsole();
var virtualConsole = (typeof virtualConsoleObj.forwardTo === "function")
  ? virtualConsoleObj.forwardTo(console, { jsdomErrors: "none" }) // jsdom 27.0.0+
  : virtualConsoleObj.sendTo(console, { omitJSDOMErrors: true });

Not 100% sure which of the new jsdomErrors values is desired. The various options are explained at the bottom of jsdom virtual consoles doc section

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions