Skip to content

Commit ec74e5d

Browse files
docs(schedules): remove internal tracker/design-doc references from comments
This repository is public. Strip internal ticket IDs and design-decision shorthand from code comments and docstrings, keeping the descriptive text. No behavior change.
1 parent 41f8d65 commit ec74e5d

9 files changed

Lines changed: 15 additions & 15 deletions

File tree

agentex/database/migrations/alembic/versions/2026_06_22_1200_add_agent_run_schedules_3b1c9d2e4f6a.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
Revises: c7a1b2d3e4f5
55
Create Date: 2026-06-22 12:00:00.000000
66
7-
Creates the agent_run_schedules table backing the scheduled-agent-runs feature
8-
(AGX1-368). Schema-only and idempotent: the table and its indexes are created
7+
Creates the agent_run_schedules table backing the scheduled-agent-runs feature.
8+
Schema-only and idempotent: the table and its indexes are created
99
with IF NOT EXISTS-style guards (Alembic create_table on a fresh table), and the
1010
indexes target the just-created table so they are non-blocking by construction.
1111
"""

agentex/openapi.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5591,7 +5591,7 @@ components:
55915591
Never carries cookies, JWTs, API keys, OAuth tokens, or request headers —
55925592
it
55935593
5594-
is creator *context* used only for AuthZ and ownership at fire time (D5/D6).'
5594+
is creator *context* used only for AuthZ and ownership at fire time.'
55955595
ScheduleInitialInput:
55965596
properties:
55975597
type:

agentex/src/api/routes/agent_run_schedules.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
# The canonical agent scheduling API. Schedules an agent *run* on each fire
3232
# (creates a fresh task + delivers the configured initial input), hiding the
33-
# underlying Temporal workflow/task-queue details (AGX1-368, D1). It replaced the
33+
# underlying Temporal workflow/task-queue details. It replaced the
3434
# earlier bare-workflow scheduler that previously owned this path.
3535
router = APIRouter(
3636
prefix="/agents/{agent_id}/schedules",
@@ -49,7 +49,7 @@ def _extract_creator_principal(principal_context: Any) -> dict[str, Any]:
4949
"""Capture the credential-free creator subset from the request principal.
5050
5151
Stores only identity selectors (principal_type / user_id / service_account_id
52-
/ account_id). Never cookies, JWTs, API keys, OAuth tokens, or headers (D5/D6).
52+
/ account_id). Never cookies, JWTs, API keys, OAuth tokens, or headers.
5353
Returns an empty dict under authz bypass / when no principal is present.
5454
"""
5555
if principal_context is None:

agentex/src/api/schemas/agent_run_schedules.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class ScheduleCreatorPrincipal(BaseModel):
2929
"""Credential-free creator identity stored with the schedule.
3030
3131
Never carries cookies, JWTs, API keys, OAuth tokens, or request headers — it
32-
is creator *context* used only for AuthZ and ownership at fire time (D5/D6).
32+
is creator *context* used only for AuthZ and ownership at fire time.
3333
"""
3434

3535
principal_type: str | None = Field(

agentex/src/domain/entities/agent_run_schedules.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def infer_initial_input_method(acp_type: ACPType) -> InitialInputMethod:
2323
"""Map an agent's ACP type to the delivery method for the initial input.
2424
2525
async / agentic agents receive the first input as an ``event/send``; sync
26-
agents receive it as a ``message/send`` (AGX1-368, D2 / Open Q5).
26+
agents receive it as a ``message/send``.
2727
"""
2828
if acp_type == ACPType.SYNC:
2929
return InitialInputMethod.MESSAGE_SEND
@@ -35,7 +35,7 @@ class AgentRunScheduleEntity(BaseModel):
3535
3636
The Postgres row is the source of truth for what each future fire should do;
3737
the Temporal Schedule is only the recurring clock and carries nothing but the
38-
schedule id (AGX1-368, D4).
38+
schedule id.
3939
4040
JSON-backed fields (``creator_principal``, ``task_params``, ``task_metadata``,
4141
``initial_input``) are stored as plain dicts so they round-trip cleanly through
@@ -68,7 +68,7 @@ class AgentRunScheduleEntity(BaseModel):
6868
)
6969
paused: bool = Field(False, description="Whether the schedule is currently paused.")
7070
# Credential-free creator context: principal_type / user_id / service_account_id /
71-
# account_id only. Never cookies, JWTs, API keys, OAuth tokens, or headers (D5/D6).
71+
# account_id only. Never cookies, JWTs, API keys, OAuth tokens, or headers.
7272
creator_principal: dict[str, Any] = Field(
7373
...,
7474
description="Credential-free creator identity used for AuthZ at fire time.",

agentex/src/domain/services/agent_run_schedule_service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ class AgentRunScheduleService:
6060
6161
The Postgres row is the source of truth for the schedule definition; the
6262
Temporal Schedule is only the recurring clock and is given nothing but the
63-
schedule row id as its workflow argument (AGX1-368, D4).
63+
schedule row id as its workflow argument.
6464
"""
6565

6666
def __init__(

agentex/src/temporal/activities/scheduled_agent_run_activities.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
"""
2-
Temporal activity for scheduled agent runs (AGX1-368).
2+
Temporal activity for scheduled agent runs.
33
44
``launch_scheduled_agent_run`` is the single activity each scheduled fire runs.
55
It loads the persisted schedule, creates a fresh Agentex task with a deterministic
@@ -180,7 +180,7 @@ async def launch_scheduled_agent_run(
180180

181181
# Re-check the stored creator principal's permission at fire time, mirroring
182182
# the JSON-RPC route's authorization order: agent.execute (the RPC endpoint
183-
# gate) then task.create (implements AGX1-368 D5's `check`). A revoked
183+
# gate) then task.create (re-checks the creator's permission at fire time). A revoked
184184
# creator stops future fires instead of running under stale ownership.
185185
# AuthorizationError (403) is a permanent denial → skip cleanly; transient
186186
# authz errors propagate so Temporal retries. Under authz bypass (local /

agentex/src/temporal/scheduled_agent_run_factory.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
in task_retention_factory.py.
55
66
Each scheduled fire creates a fresh Agentex task and delivers the schedule's
7-
configured initial input under the *stored creator principal* (AGX1-368, D5)
7+
configured initial input under the *stored creator principal* —
88
not as an agent identity. So the AgentsACPUseCase is rebuilt per fire with an
99
AuthorizationService whose principal_context is that fire's creator principal and
1010
whose agent_identity is None, attributing task ownership and AuthZ checks to the
@@ -51,7 +51,7 @@ class _ScheduledRunRequest:
5151
Carries the stored creator principal as ``state.principal_context`` with no
5252
``agent_identity`` (so AuthZ attributes ownership to the creator, not a
5353
service) and no headers (so no live user credentials — cookies, API keys —
54-
are forwarded downstream; D5/D6). ``build_delegation_headers`` returns an
54+
are forwarded downstream). ``build_delegation_headers`` returns an
5555
empty mapping when there are no inbound credential headers, which is exactly
5656
the intended behavior here.
5757
"""

agentex/src/temporal/workflows/scheduled_agent_run_workflow.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
"""
2-
Scheduled agent run workflow (AGX1-368).
2+
Scheduled agent run workflow.
33
44
Started by a Temporal Schedule on each cron / interval fire. The workflow is
55
deliberately thin: it passes only the schedule id and a per-fire token to a

0 commit comments

Comments
 (0)