Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 7ff31a2

Browse files
authored
Merge pull request #150 from scalecube/update-services
Update services to -RC3
2 parents 01b9a3e + 5649934 commit 7ff31a2

File tree

4 files changed

+2
-21
lines changed

4 files changed

+2
-21
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
<properties>
2525
<scalecube-commons.version>1.0.4</scalecube-commons.version>
26-
<scalecube-services.version>2.10.0-RC2</scalecube-services.version>
26+
<scalecube-services.version>2.10.0-RC3</scalecube-services.version>
2727
<scalecube-benchmarks.version>1.2.2</scalecube-benchmarks.version>
2828
<scalecube-config.version>0.4.3</scalecube-config.version>
2929
<reactor.version>Dysprosium-SR8</reactor.version>

services-gateway-client-transport/src/main/java/io/scalecube/services/gateway/transport/GatewayClientTransports.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import io.netty.buffer.ByteBuf;
44
import io.rsocket.Payload;
5-
import io.scalecube.services.api.ServiceMessage;
65
import io.scalecube.services.gateway.transport.http.HttpGatewayClient;
76
import io.scalecube.services.gateway.transport.http.HttpGatewayClientCodec;
87
import io.scalecube.services.gateway.transport.rsocket.RSocketGatewayClient;
@@ -12,22 +11,13 @@
1211
import io.scalecube.services.transport.api.ClientTransport;
1312
import io.scalecube.services.transport.api.DataCodec;
1413
import io.scalecube.services.transport.api.HeadersCodec;
15-
import io.scalecube.services.transport.api.ReferenceCountUtil;
1614
import java.util.function.Function;
17-
import reactor.core.publisher.Hooks;
1815

1916
public class GatewayClientTransports {
2017

2118
private static final String CONTENT_TYPE = "application/json";
2219
private static final HeadersCodec HEADERS_CODEC = HeadersCodec.getInstance(CONTENT_TYPE);
2320

24-
static {
25-
Hooks.onNextDropped(
26-
obj ->
27-
ReferenceCountUtil.safestRelease(
28-
obj instanceof ServiceMessage ? ((ServiceMessage) obj).data() : obj));
29-
}
30-
3121
public static final GatewayClientCodec<ByteBuf> WEBSOCKET_CLIENT_CODEC =
3222
new WebsocketGatewayClientCodec(DataCodec.getInstance(CONTENT_TYPE));
3323
public static final GatewayClientCodec<Payload> RSOCKET_CLIENT_CODEC =

services-gateway-netty/src/main/java/io/scalecube/services/gateway/GatewayTemplate.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
package io.scalecube.services.gateway;
22

3-
import io.scalecube.services.api.ServiceMessage;
43
import java.net.InetSocketAddress;
54
import org.slf4j.Logger;
65
import org.slf4j.LoggerFactory;
7-
import reactor.core.publisher.Hooks;
86
import reactor.core.publisher.Mono;
97
import reactor.netty.DisposableServer;
108
import reactor.netty.http.server.HttpServer;
@@ -14,14 +12,6 @@ public abstract class GatewayTemplate implements Gateway {
1412

1513
private static final Logger LOGGER = LoggerFactory.getLogger(GatewayTemplate.class);
1614

17-
static {
18-
Hooks.onNextDropped(
19-
obj -> {
20-
ReferenceCountUtil.safestRelease(
21-
obj instanceof ServiceMessage ? ((ServiceMessage) obj).data() : obj);
22-
});
23-
}
24-
2515
protected final GatewayOptions options;
2616

2717
protected GatewayTemplate(GatewayOptions options) {

services-gateway-tests/src/test/java/io/scalecube/services/gateway/websocket/WebsocketClientConnectionTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,7 @@ void testKeepalive()
190190
@Override
191191
public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception {
192192
if (msg instanceof PongWebSocketFrame) {
193+
((PongWebSocketFrame) msg).release();
193194
keepaliveLatch.countDown();
194195
} else {
195196
super.channelRead(ctx, msg);

0 commit comments

Comments
 (0)