Skip to content

Commit 74dfb60

Browse files
committed
Fixed io.scalecube.services.ServiceCall.onMessage
1 parent 23f09ff commit 74dfb60

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

services-api/src/main/java/io/scalecube/services/ServiceCall.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -469,19 +469,15 @@ private static MethodInfo getMethodInfo(Class<?> serviceInterface, Method method
469469
}
470470

471471
private ServiceMessage onMessage(ServiceMessage message, Type returnType) {
472-
if (returnType == null) {
473-
return throwIfError(message);
474-
} else {
475-
return throwIfError(
476-
dataDecoder.decodeData(
477-
message, isWildcardType(returnType) ? getDataType(message) : returnType));
472+
if (returnType != null) {
473+
final var dataType = isWildcardType(returnType) ? getDataType(message) : returnType;
474+
message = dataDecoder.decodeData(message, dataType);
478475
}
479-
}
480476

481-
private ServiceMessage throwIfError(ServiceMessage message) {
482477
if (message.isError() && message.hasData(ErrorData.class)) {
483478
throw Exceptions.propagate(errorMapper.toError(message));
484479
}
480+
485481
return message;
486482
}
487483

0 commit comments

Comments
 (0)