fix(vpc_gw_dhcp): Properly set fields that should default to true (#1058)

Author: Tuetuopay

scaleway/resource_vpc_public_gateway_dhcp.go

@@ -53,8 +53,8 @@ func resourceScalewayVPCPublicGatewayDHCP() *schema.Resource {
 			},
 			"enable_dynamic": {
 				Type:        schema.TypeBool,
-				Computed:    true,
 				Optional:    true,
+				Default:     true,
 				Description: "Whether to enable dynamic pooling of IPs. By turning the dynamic pool off, only pre-existing DHCP reservations will be handed out. Defaults to true.",
 			},
 			"valid_lifetime": {
@@ -77,14 +77,14 @@ func resourceScalewayVPCPublicGatewayDHCP() *schema.Resource {
 			},
 			"push_default_route": {
 				Type:        schema.TypeBool,
-				Computed:    true,
 				Optional:    true,
+				Default:     true,
 				Description: "Whether the gateway should push a default route to DHCP clients or only hand out IPs. Defaults to true",
 			},
 			"push_dns_server": {
 				Type:        schema.TypeBool,
-				Computed:    true,
 				Optional:    true,
+				Default:     true,
 				Description: "Whether the gateway should push custom DNS servers to clients. This allows for instance hostname -> IP resolution. Defaults to true.",
 			},
 			"dns_server_override": {

scaleway/resource_vpc_public_gateway_dhcp_test.go

@@ -44,7 +44,7 @@ func testAccCheckScalewayVPCPublicGatewayDHCPExists(tt *TestTools, n string) res
 			return err
 		}
 
-		_, err = vpcgwAPI.GetDHCP(&vpcgw.GetDHCPRequest{
+		dhcp, err := vpcgwAPI.GetDHCP(&vpcgw.GetDHCPRequest{
 			DHCPID: ID,
 			Zone:   zone,
 		})
@@ -53,6 +53,17 @@ func testAccCheckScalewayVPCPublicGatewayDHCPExists(tt *TestTools, n string) res
 			return err
 		}
 
+		// Test default values
+		if !dhcp.EnableDynamic {
+			return fmt.Errorf("enable_dynamic is false, should default to true")
+		}
+		if !dhcp.PushDefaultRoute {
+			return fmt.Errorf("push_default_route is false, should default to true")
+		}
+		if !dhcp.PushDNSServer {
+			return fmt.Errorf("push_dns_server is false, should default to true")
+		}
+
 		return nil
 	}
 }