chore: remove usage of panic (#3598)

* chore: remove usage of panic

* Fix lint

Author: remyleone

.github/workflows/lint.yml

@@ -48,6 +48,8 @@ jobs:
         run: make tfproviderlint
       - name: Run tfproviderlintx
         run: make tfproviderlintx
+      - name: Run gopaniccheck
+        run: make gopaniccheck
 
   tfproviderdocs:
     name: tfproviderdocs

GNUmakefile

@@ -66,6 +66,9 @@ tfproviderdocs:
 tfproviderlintx:
 	go tool tfproviderlintx -S013=false -XR001=false -XS002=false ./...
 
+gopaniccheck:
+	go tool gopaniccheck ./...
+
 format_examples:
 	terraform fmt -recursive examples
 

go.mod

@@ -182,6 +182,7 @@ require (
 )
 
 tool (
+	github.com/bflad/gopaniccheck/cmd/gopaniccheck
 	github.com/bflad/tfproviderdocs
 	github.com/bflad/tfproviderlint/cmd/tfproviderlint
 	github.com/bflad/tfproviderlint/cmd/tfproviderlintx

internal/acctest/acctest_test.go

@@ -343,7 +343,9 @@ var objectBodyCassette = `{
 func newRequest(method, url string, body io.Reader) *http.Request {
 	req, err := http.NewRequestWithContext(context.Background(), method, url, body)
 	if err != nil {
-		panic(err) // lintignore: R009
+		// In test context, we can log the error and return nil since this is a test helper
+		// The test will fail when trying to use the nil request
+		return nil
 	}
 
 	return req

internal/acctest/vcr.go

@@ -102,12 +102,16 @@ func cassetteBodyMatcher(request *http.Request, cassette cassette.Request) bool
 
 	r, err := request.GetBody()
 	if err != nil {
-		panic(fmt.Errorf("cassette body matcher: failed to copy request body: %w", err)) // lintignore: R009
+		logging.L.Errorf("cassette body matcher: failed to copy request body: %v", err)
+
+		return false
 	}
 
 	requestBody, err := io.ReadAll(r)
 	if err != nil {
-		panic(fmt.Errorf("cassette body matcher: failed to read actualRequest body: %w", err)) // lintignore: R009
+		logging.L.Errorf("cassette body matcher: failed to read actualRequest body: %v", err)
+
+		return false
 	}
 
 	// Try to match raw bodies if they are not JSON (ex: cloud-init config)
@@ -127,7 +131,9 @@ func cassetteBodyMatcher(request *http.Request, cassette cassette.Request) bool
 	if !json.Valid(requestBody) {
 		requestValues, err := url.ParseQuery(string(requestBody))
 		if err != nil {
-			panic(fmt.Errorf("cassette body matcher: failed to parse body as url values: %w", err)) // lintignore: R009
+			logging.L.Errorf("cassette body matcher: failed to parse body as url values: %v", err)
+
+			return false
 		}
 
 		// Remove keys that should be ignored during comparison
@@ -140,7 +146,9 @@ func cassetteBodyMatcher(request *http.Request, cassette cassette.Request) bool
 
 	err = json.Unmarshal(requestBody, &requestJSON)
 	if err != nil {
-		panic(fmt.Errorf("cassette body matcher: failed to parse request body as json: %w", err)) // lintignore: R009
+		logging.L.Errorf("cassette body matcher: failed to parse request body as json: %v", err)
+
+		return false
 	}
 
 	err = json.Unmarshal([]byte(cassette.Body), &cassetteJSON)