feat: update stack validation, relax regexes, enforce SCM exclusivity, add CI

- Update stack validation: remove EOL scalingo-18, add scalingo-24
- Extend TLD max length to 63 chars for domain and domain_aliases validation
- Simplify domain_aliases validation logic
- Support + in email local part for collaborators validation
- Simplify ELK log drain URL validation to accept auth, ports, and paths
- Add lifecycle precondition to enforce github/gitlab mutual exclusivity
- Add CI workflow with terraform fmt, init, and validate

Author: josephpage

.github/workflows/ci.yml

@@ -0,0 +1,14 @@
+name: CI
+on:
+  pull_request:
+  push:
+    branches: [main]
+jobs:
+  terraform:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: hashicorp/setup-terraform@v3
+      - run: terraform fmt -check -recursive
+      - run: terraform init -backend=false
+      - run: terraform validate

app.tf

@@ -12,6 +12,13 @@ resource "scalingo_app" "app" {
 
   sticky_session = var.sticky_session
   router_logs    = var.router_logs
+
+  lifecycle {
+    precondition {
+      condition     = !(var.github_integration != null && var.gitlab_integration != null)
+      error_message = "Only one of github_integration or gitlab_integration can be set, not both."
+    }
+  }
 }
 
 resource "scalingo_container_type" "containers" {

variables.tf

@@ -9,8 +9,8 @@ variable "stack" {
   default     = "scalingo-22"
 
   validation {
-    condition     = contains(["scalingo-18", "scalingo-20", "scalingo-22"], var.stack)
-    error_message = "The stack value must be one of the following: scalingo-18, scalingo-20, scalingo-22"
+    condition     = contains(["scalingo-20", "scalingo-22", "scalingo-24"], var.stack)
+    error_message = "The stack value must be one of the following: scalingo-20, scalingo-22, scalingo-24"
   }
 }
 
@@ -102,7 +102,7 @@ variable "additionnal_collaborators" {
   validation {
     condition = length([
       for email in var.additionnal_collaborators :
-      email if regex("^([a-zA-Z0-9_\\-\\.]+)@([a-zA-Z0-9_\\-\\.]+)\\.([a-zA-Z]{2,5})$", email) == false
+      email if regex("^([a-zA-Z0-9_\\-\\.\\+]+)@([a-zA-Z0-9_\\-\\.]+)\\.([a-zA-Z]{2,63})$", email) == false
     ]) == 0
     error_message = "The list of emails must contain only valid emails."
   }
@@ -163,7 +163,7 @@ variable "domain" {
   nullable    = true
 
   validation {
-    condition     = var.domain == null || can(length(regex("^([a-zA-Z0-9_\\-\\.]+)\\.([a-zA-Z]{2,5})$", var.domain)) > 0)
+    condition     = var.domain == null || can(length(regex("^([a-zA-Z0-9_\\-\\.]+)\\.([a-zA-Z]{2,63})$", var.domain)) > 0)
     error_message = "The domain name must be a valid domain name."
   }
 }
@@ -177,7 +177,7 @@ variable "domain_aliases" {
   validation {
     condition = length([
       for domain in var.domain_aliases :
-      domain if !can(length(regex("^([a-zA-Z0-9_\\-\\.]+)\\.([a-zA-Z]{2,6})$", domain)) == 0)
+      domain if !can(regex("^([a-zA-Z0-9_\\-\\.]+)\\.([a-zA-Z]{2,63})$", domain))
     ]) == 0
     error_message = "The list of domain names must contain only valid domain names."
   }
@@ -207,8 +207,8 @@ variable "log_drains" {
   validation {
     condition = length([
       for drain in var.log_drains :
-      drain if drain.type == "elk" && can(length(regex("^https?://([a-zA-Z0-9_\\-\\.]+)\\.([a-zA-Z]{2,5})$", drain.url)) == 0)
+      drain if drain.type == "elk" && !can(regex("^https?://.+", drain.url))
     ]) == 0
-    error_message = "Log drains of type \"elk\" must have a valid url."
+    error_message = "Log drains of type \"elk\" must have a valid url (starting with http:// or https://)."
   }
 }