f

Author: tmacro

tests/unit/models/NotificationConfiguration.spec.js

@@ -294,7 +294,7 @@ describe('NotificationConfiguration.restrictSupportedNotificationBasedOnLifecycl
 describe('NotificationConfiguration.getConfigXML - XML escaping for special characters', () => {
     const specialCharacters = ['&', '<', '>', '"', "'"];
 
-    specialCharacters.forEach(char =>
+    specialCharacters.forEach(char => {
         it(`should escape \`${char}\` in notification ID and generate valid XML`, done => {
             const config = {
                 queueConfig: [{
@@ -313,10 +313,8 @@ describe('NotificationConfiguration.getConfigXML - XML escaping for special char
                 assert.strictEqual(queueConfig.Id[0], `test-id${char}value`);
                 done();
             });
-        })
-    );
+        });
 
-    specialCharacters.forEach(char =>
         it(`should escape \`${char}\` in queue ARN`, done => {
             const config = {
                 queueConfig: [{
@@ -335,10 +333,8 @@ describe('NotificationConfiguration.getConfigXML - XML escaping for special char
                 assert.strictEqual(queueConfig.Queue[0], `arn:scality:bucketnotif:::queue${char}name`);
                 done();
             });
-        })
-    );
+        });
 
-    specialCharacters.forEach(char =>
         it(`should escape \`${char}\` in filter rule name and value`, done => {
             const config = {
                 queueConfig: [{
@@ -362,63 +358,6 @@ describe('NotificationConfiguration.getConfigXML - XML escaping for special char
                 assert.strictEqual(filterRule.Value[0], `logs/${char}path`);
                 done();
             });
-        })
-    );
-
-    it('should escape multiple special characters across all fields', done => {
-        const config = {
-            queueConfig: [{
-                id: 'id<test>&\'data\'',
-                queueArn: 'arn:scality:bucketnotif:::target&<queue>',
-                events: ['s3:ObjectCreated:*'],
-                filterRules: [{
-                    name: 'Prefix',
-                    value: '<path>&"value"',
-                }],
-            }],
-        };
-
-        const xml = NotificationConfiguration.getConfigXML(config);
-
-        parseString(xml, (err, result) => {
-            assert.ifError(err);
-            const queueConfig = result.NotificationConfiguration.QueueConfiguration[0];
-            assert.strictEqual(queueConfig.Id[0], 'id<test>&\'data\'');
-            assert.strictEqual(queueConfig.Queue[0], 'arn:scality:bucketnotif:::target&<queue>');
-            const filterRule = queueConfig.Filter[0].S3Key[0].FilterRule[0];
-            assert.strictEqual(filterRule.Value[0], '<path>&"value"');
-            done();
-        });
-    });
-
-    it('should handle multiple filter rules with special characters', done => {
-        const config = {
-            queueConfig: [{
-                id: 'test-id',
-                queueArn: 'arn:scality:bucketnotif:::target',
-                events: ['s3:ObjectCreated:*'],
-                filterRules: [
-                    {
-                        name: 'Prefix',
-                        value: 'logs/<app>&env',
-                    },
-                    {
-                        name: 'Suffix',
-                        value: '.log&.txt',
-                    },
-                ],
-            }],
-        };
-
-        const xml = NotificationConfiguration.getConfigXML(config);
-
-        parseString(xml, (err, result) => {
-            assert.ifError(err);
-            const queueConfig = result.NotificationConfiguration.QueueConfiguration[0];
-            const filterRules = queueConfig.Filter[0].S3Key[0].FilterRule;
-            assert.strictEqual(filterRules[0].Value[0], 'logs/<app>&env');
-            assert.strictEqual(filterRules[1].Value[0], '.log&.txt');
-            done();
         });
     });
 });