ARSN-422: add error for query string on post

Will Toozs · Will Toozs · commit e109d2dcfffd · 2024-07-17T15:11:44.000+02:00
diff --git a/lib/s3routes/routes/routePOST.ts b/lib/s3routes/routes/routePOST.ts
@@ -58,7 +58,12 @@ export default function routePOST(
                     corsHeaders));
     }
 
-    if (objectKey === undefined && Object.keys(query).length === 0) {
+    if (objectKey === undefined) {
+        if (Object.keys(query).length > 0) {
+            return routesUtils.responseNoBody(errors.InvalidArgument
+                .customizeDescription("Query String Parameters not allowed on POST requests."), null,
+                response, 400, log);
+        }
         return api.callPostObject!('objectPost', request, response, log, (err, resHeaders) => routesUtils.responseNoBody(err, resHeaders, response, 204, log));
     }
 

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,12 @@ export default function routePOST(`
`58`	`58`	`corsHeaders));`
`59`	`59`	`}`
`60`	`60`
`61`		`- if (objectKey === undefined && Object.keys(query).length === 0) {`
	`61`	`+ if (objectKey === undefined) {`
	`62`	`+ if (Object.keys(query).length > 0) {`
	`63`	`+ return routesUtils.responseNoBody(errors.InvalidArgument`
	`64`	`+ .customizeDescription("Query String Parameters not allowed on POST requests."), null,`
	`65`	`+ response, 400, log);`
	`66`	`+ }`
`62`	`67`	`return api.callPostObject!('objectPost', request, response, log, (err, resHeaders) => routesUtils.responseNoBody(err, resHeaders, response, 204, log));`
`63`	`68`	`}`
`64`	`69`