Merge pull request #32 from scality/ft/new_warnings

Ft/new warnings

Author: Michael Zapata

bin/mdlint.js

@@ -1,9 +1,9 @@
 #!/usr/bin/env node
 
-"use strict"; // eslint-disable-line strict
+'use strict'; // eslint-disable-line strict
 
-const commander = require("commander");
-const markdownlint = require("markdownlint");
+const commander = require('commander');
+const markdownlint = require('markdownlint');
 
 const files = commander.parse(process.argv).args;
 
@@ -13,7 +13,7 @@ const config = {
     MD007: false,  // Unordered list indentation
     MD024: false,  // Multiple headers with the same content
     MD027: false,  // Multiple spaces after blockquote symbol
-    MD029: { style: "ordered" }, // Ordered list item prefix
+    MD029: { style: 'ordered' }, // Ordered list item prefix
     MD034: false,  // Bare URL used
     MD040: false,  // Fenced code blocks should have a language specified
 };

index.js

@@ -1,5 +1,5 @@
 module.exports = {
-    extends: "airbnb/base",
+    extends: 'airbnb/base',
 
     env: {
         browser: false,
@@ -8,26 +8,48 @@ module.exports = {
     },
 
     rules: {
-        "strict": [2, "global"],
-        "indent": [2, 4],
-        "no-mixed-spaces-and-tabs": 2,
-        "max-len": [2, 80, 4],
-        "quotes": 0,
-        "semi": [2, "always"],
-        "curly": 0,
-        "space-before-keywords": 2,
-        "space-before-function-paren": [2, { anonymous: "always",
-                                             named: "never"} ],
-        "comma-dangle": 1,
-        "camelcase": [2, { properties: "always" }],
-        "id-length": 0,
-        "no-shadow": 0,
-        "valid-jsdoc": 1,
-        "eol-last": 2,
-        "no-multiple-empty-lines": [ 2, { max: 2, maxEOF: 1 } ],
-        "no-console": 2,
-        "object-shorthand": 1,
-        "quote-props": [1, "consistent-as-needed"],
-        "prefer-template": 1,
+        'strict': [2, 'global'],
+        'indent': [2, 4],
+        'no-mixed-spaces-and-tabs': 2,
+        'max-len': [2, 80, 4],
+        'quotes': [1, 'single', 'avoid-escape'],
+        'semi': [2, 'always'],
+        'curly': 0,
+        'space-before-function-paren': [2, { anonymous: 'always',
+                                             named: 'never' }],
+        'comma-dangle': 1,
+        'camelcase': [2, { properties: 'always' }],
+        'id-length': 0,
+        'no-shadow': 0,
+        'valid-jsdoc': 1,
+        'eol-last': 2,
+        'no-multiple-empty-lines': [2, { max: 2, maxEOF: 1 }],
+        'no-console': 2,
+        'object-shorthand': 1,
+        'quote-props': [1, 'consistent-as-needed'],
+        'prefer-template': 1,
+        'array-bracket-spacing': [1, 'never'],
+        'keyword-spacing': [1, {
+            before: true,
+            after: true,
+            overrides: {
+                return: { after: true },
+                throw: { after: true },
+                case: { after: true },
+            },
+        }],
+        'linebreak-style': [1, 'unix'],
+        'new-cap': [1, { newIsCap: true }],
+        'space-in-parens': [1, 'never'],
+        'consistent-return': 1,
+        'prefer-arrow-callback': 1,
+        'no-param-reassign': [1, { props: true }],
+        'arrow-body-style': [1, 'as-needed'],
+        'prefer-rest-params': 1,
+        'no-unneeded-ternary': [1, { defaultAssignment: false }],
+        'arrow-parens': [1, 'as-needed'],
+        'no-return-assign': [1, 'always'],
+        'prefer-const': 1,
+        'array-callback-return': 1,
     },
 };

package.json

@@ -20,9 +20,9 @@
         "markdownlint": "^0.0.8"
     },
     "devDependencies": {
-        "babel-eslint": "^4.1.3",
-        "eslint": "^1.10.3",
-        "eslint-config-airbnb": "^1.0.0"
+        "babel-eslint": "^5.0.0",
+        "eslint": "^2.4.0",
+        "eslint-config-airbnb": "^6.1.0"
     },
     "keywords": [
         "eslint",