Drop js-yaml

It is not available in github runners, so use yq to convert to JSON
instead.

Issue: ZENKO-5132

Author: francoisferrand

.github/actions/create-component-deployments/action.yaml

@@ -64,6 +64,13 @@ runs:
         cat /tmp/changed-deps.yaml
         echo "deps-file=/tmp/changed-deps.yaml" >> "$GITHUB_OUTPUT"
 
+    - name: Convert deps.yaml to JSON
+      id: json
+      shell: bash
+      run: |
+        yq -o=json '${{ steps.filter.outputs.deps-file || inputs.deps-file }}' > /tmp/changed-deps.json
+        echo "deps-file=/tmp/changed-deps.json" >> "$GITHUB_OUTPUT"
+
     - name: Parse component repos from deps.yaml
       id: parse
       uses: actions/github-script@v7
@@ -72,7 +79,7 @@ runs:
         script: |
           const { parseDeps } = require('${{ github.action_path }}/parse-deps.js');
           const selfRepo = process.env.GITHUB_REPOSITORY || 'scality/zenko';
-          const { components, repos } = parseDeps('${{ steps.filter.outputs.deps-file || inputs.deps-file }}', selfRepo);
+          const { components, repos } = parseDeps('${{ steps.json.outputs.deps-file }}', selfRepo);
 
           if (components.length === 0) {
             core.info('No component repos found in deps.yaml');

.github/actions/create-component-deployments/parse-deps.js

@@ -1,6 +1,5 @@
 // @ts-check
 const fs = require('fs');
-const yaml = require('js-yaml');
 
 /**
  * Strip @sha256:... digest suffix from a tag.
@@ -14,12 +13,12 @@ function stripDigest(tag) {
 /**
  * Parse deps.yaml and extract component info for ghcr.io/scality/* images.
  *
- * @param {string} depsFile - Path to deps.yaml
+ * @param {string} depsFile - Path to deps JSON file (converted from deps.yaml)
  * @param {string} selfRepo - The current repo (org/name) to exclude from results
  * @returns {{ components: Array<{repo: string, ref: string, image: string}>, repos: string[] }}
  */
 function parseDeps(depsFile, selfRepo) {
-    const deps = yaml.load(fs.readFileSync(depsFile, 'utf8'));
+    const deps = JSON.parse(fs.readFileSync(depsFile, 'utf8'));
     const seen = new Set();
     const components = [];
     const normalizedSelfRepo = (selfRepo || '').toLowerCase();

tests/workflows/parse-deps.spec.ts

@@ -1,8 +1,17 @@
 import path from 'path';
+import fs from 'fs';
+import yaml from 'js-yaml';
 
 const { parseDeps, stripDigest } = require('../../.github/actions/create-component-deployments/parse-deps');
 
-const depsFile = path.join(__dirname, '../../solution/deps.yaml');
+/** Convert a YAML file to a temporary JSON file (mirrors the yq step in action.yaml). */
+function yamlToJson(yamlPath: string): string {
+    const jsonPath = fs.mkdtempSync(path.join(require('os').tmpdir(), 'deps-')) + '/deps.json';
+    fs.writeFileSync(jsonPath, JSON.stringify(yaml.load(fs.readFileSync(yamlPath, 'utf8'))));
+    return jsonPath;
+}
+
+const depsFile = yamlToJson(path.join(__dirname, '../../solution/deps.yaml'));
 
 describe('parseDeps', () => {
     it('extracts scality components from deps.yaml', () => {
@@ -71,7 +80,7 @@ describe('parseDeps', () => {
     });
 
     it('sets empty repo for playground images', () => {
-        const testDeps = path.join(__dirname, 'test-deps.yaml');
+        const testDeps = yamlToJson(path.join(__dirname, 'test-deps.yaml'));
         const { components } = parseDeps(testDeps, 'scality/zenko');
         const playground = components.find((c: { image: string }) => c.image.includes('playground'));
 

tests/workflows/release.spec.ts

@@ -381,12 +381,6 @@ test.each([
                 }
             }],
             'create-deployments': [{
-                before: 'Checkout',
-                mockWith: {
-                    name: 'Install js-yaml globally',
-                    run: 'npm install -g js-yaml ; echo "NODE_PATH=$(npm root -g)" >> "$GITHUB_ENV"'
-                },
-            }, {
                 name: 'Create release deployments',
                 mockWith: {
                     with: {

tests/workflows/test-create-component-deployments.yaml

@@ -11,11 +11,6 @@ jobs:
   test-deployments:
     runs-on: ubuntu-latest
     steps:
-      - name: Install js-yaml globally
-        run: |
-          npm install -g js-yaml
-          echo "NODE_PATH=$(npm root -g)" >> "$GITHUB_ENV"
-
       - name: Create component deployments
         uses: ./.github/actions/create-component-deployments
         with: