Fix ingestion from raft session >=10

Issue: BB-759

Author: francoisferrand

lib/queuePopulator/IngestionProducer.js

@@ -132,9 +132,9 @@ class IngestionProducer {
                 });
                 IngestionPopulatorMetrics.onIngestionSourceOp('getRaftId', 'error');
                 return done(err);
-            } else if (data && data[0]) {
+            } else if (data) {
                 IngestionPopulatorMetrics.onIngestionSourceOp('getRaftId', 'success');
-                return done(null, data[0]);
+                return done(null, data);
             }
             this.log.error(`empty response for raftid of ${bucketName}`,
             { method: 'getRaftId', bucketName });

tests/functional/ingestion/IngestionProducer.js

@@ -158,4 +158,15 @@ describe('ingestion producer tests with mock', () => {
             return done();
         });
     });
+
+    it('should return the full raft ID for multi-digit raft sessions',
+    done => {
+        this.iProducer.getRaftId('bucket-raft13', (err, res) => {
+            assert.ifError(err);
+            assert.strictEqual(typeof res, 'string');
+            // must return '13', not '1' (first character)
+            assert.strictEqual(res, '13');
+            return done();
+        });
+    });
 });

tests/functional/utils/mockRes.json

@@ -37,6 +37,10 @@
                 "resType": "raftId",
                 "name": "bucket2"
             },
+            "/_/metadata/admin/buckets/bucket-raft13/id": {
+                "resType": "raftId",
+                "name": "bucket-raft13"
+            },
             "/_/metadata/admin/raft_sessions/1/log": {
                 "resType": "raftLogs",
                 "name": "1"
@@ -678,7 +682,8 @@
     },
     "raftId": {
         "bucket1": 1,
-        "bucket2": 5
+        "bucket2": 5,
+        "bucket-raft13": 13
     },
     "raftInformation": {
         "1": {