fixup! Refactor: pass scanId as parameter instead of instance field and fix metric timing

fix(tests): update tests to reflect messageId removal and scanId parameter changes

Author: benzekrimaha

tests/unit/lifecycle/LifecycleConductor.spec.js

@@ -237,20 +237,22 @@ describe('Lifecycle Conductor', () => {
                 getData: (_, cb) => cb(null, null, null),
                 setData: (path, data, version, cb) => cb(null, { version: 1 }),
             };
+            conductor._producer = { send: (msg, cb) => cb(null, {}) };
 
             sinon.stub(conductor, '_controlBacklog').callsFake(cb => cb(null));
+            sinon.stub(conductor, 'listBuckets')
+                .callsFake((queue, scanId, log, cb) => {
+                    // Verify scanId is a valid UUID
+                    const uuidRegex = /^[0-9a-f]{8}-[0-9a-f]{4}-4[0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$/i;
+                    assert(uuidRegex.test(scanId),
+                        `conductorScanId should be a valid UUID v4, got: ${scanId}`);
+                    cb(null, 0);
+                });
             const metricStub = sinon.stub(LifecycleMetrics, 'onConductorFullScan');
 
             conductor.processBuckets(err => {
                 assert.ifError(err);
                 assert(metricStub.calledOnce);
-                const scanId = metricStub.firstCall.args[0];
-                assert(scanId);
-                assert(typeof scanId === 'string');
-                // Validate UUID v4 format: 8-4-4-4-12 hex characters
-                const uuidRegex = /^[0-9a-f]{8}-[0-9a-f]{4}-4[0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$/i;
-                assert(uuidRegex.test(scanId), 
-                    `conductorScanId should be a valid UUID v4, got: ${scanId}`);
                 done();
             });
         });