Refactor: pass scanId as parameter instead of instance field

In this commit we refactor conductorScanId to be passed as a parameter through the call chain
instead of storing it as an instance field (_scanId), as scanId is only relevant within the context of a single scan execution passing it as a parameter makes dependencies explicit and Reduces instance state and improves code clarity

Issue: BB-740

Author: benzekrimaha

extensions/lifecycle/conductor/LifecycleConductor.js

@@ -488,7 +488,7 @@ class LifecycleConductor {
             log.error('lifecycle batch failed', {
                 error: err,
                 unknownCanonicalIds,
-                conductorScanId: this._scanId,
+                conductorScanId: scanId,
                 fullScanElapsedMs: elapsedMs,
                 nBucketsListed,
                 workflowsQueued: messageDeliveryReports,
@@ -503,7 +503,7 @@ class LifecycleConductor {
                 nBucketsQueued,
                 nLifecycledBuckets,
                 unknownCanonicalIds,
-                conductorScanId: this._scanId,
+                conductorScanId: scanId,
                 fullScanElapsedMs: elapsedMs,
                 nBucketsListed,
                 workflowsQueued: messageDeliveryReports,
@@ -532,7 +532,7 @@ class LifecycleConductor {
         });
     }
 
-    listZookeeperBuckets(queue, log, cb) {
+    listZookeeperBuckets(queue, scanId, log, cb) {
         const zkBucketsPath = this.getBucketsZkPath();
         this._zkClient.getChildren(
             zkBucketsPath,
@@ -615,7 +615,7 @@ class LifecycleConductor {
         });
     }
 
-    listBucketdBuckets(queue, initMarker, log, cb) {
+    listBucketdBuckets(queue, initMarker, scanId, log, cb) {
         let isTruncated = true;
         let marker = initMarker;
         let nEnqueued = 0;
@@ -716,7 +716,7 @@ class LifecycleConductor {
         );
     }
 
-    listMongodbBuckets(queue, log, cb) {
+    listMongodbBuckets(queue, scanId, log, cb) {
         let nEnqueued = 0;
         const start = new Date();