fixup! oplog: Update pipeline on Mongo >= 6.0 if match stage is unchanged

fixup! oplog: Update pipeline on Mongo >= 6.0 if match stage is unchanged

Author: delthas

extensions/oplogPopulator/modules/Connector.js

@@ -314,21 +314,22 @@ class Connector extends EventEmitter {
      * That is why we use updateConnectorConfig() instead of
      * updateConnectorPipeline()
      * @param {boolean} [doUpdate=false] updates connector if true
-     * @param {boolean} [updateMatchStage=true] when false, only update
-     * if the $match stage has not changed (to protect resume tokens
-     * on MongoDB >= 6.0)
+     * @param {boolean} [updateSupported=true] whether full pipeline updates
+     * (including match stage changes) are supported. When false, the update
+     * is only applied if the match stage has not changed, to protect resume
+     * tokens on MongoDB >= 6.0.
      * @returns {Promise|boolean} connector did update
      * @throws {InternalError}
      */
-    async updatePipeline(doUpdate = false, updateMatchStage = true) {
+    async updatePipeline(doUpdate = false, updateSupported = true) {
         // Only update when buckets changed and when not already updating
         if (!this._state.bucketsGotModified || this._state.isUpdating) {
             return false;
         }
         this._config.pipeline = this._getPipeline([...this._buckets]);
         try {
             if (doUpdate && this._isRunning) {
-                if (!updateMatchStage) {
+                if (!updateSupported) {
                     const currentConfig = await this._kafkaConnect.getConnectorConfig(this._name);
                     const currentPipeline = currentConfig.pipeline
                         ? JSON.parse(currentConfig.pipeline) : [];

tests/unit/oplogPopulator/Connector.js

@@ -258,7 +258,7 @@ describe('Connector', () => {
             assert(updateStub.notCalled);
         });
 
-        it('should update when updateMatchStage is false and match stages are the same', async () => {
+        it('should update when updateSupported is false and match stages are the same', async () => {
             const matchStage = { $match: { 'ns.coll': { $in: ['bucket1'] } } };
             const newPipeline = JSON.stringify([matchStage, { $set: { 'fullDocument.value.location': {} } }]);
             connector._state.bucketsGotModified = true;
@@ -275,7 +275,7 @@ describe('Connector', () => {
             assert(updateStub.calledOnce);
         });
 
-        it('should skip update when updateMatchStage is false and match stages differ', async () => {
+        it('should skip update when updateSupported is false and match stages differ', async () => {
             const newPipeline = JSON.stringify([
                 { $match: { 'ns.coll': { $in: ['bucket1'] } } },
             ]);