✨ add the versioningPreprocessing call to copy object when needed

Issue: CLDSRV-632

Author: DarkIsDude

lib/api/apiUtils/object/createAndStoreObject.js

@@ -218,6 +218,7 @@ function createAndStoreObject(bucketName, bucketMD, objectKey, objMD, authInfo,
                     metadataStoreParams.contentMD5 = constants.emptyFileMd5;
                     return next(null, null, null);
                 }
+
                 // Handle mdOnlyHeader as a metadata only operation. If
                 // the object in question is actually 0 byte or has a body size
                 // then handle normally.
@@ -244,6 +245,7 @@ function createAndStoreObject(bucketName, bucketMD, objectKey, objMD, authInfo,
                     return next(null, dataGetInfo, _md5);
                 }
             }
+
             return dataStore(objectKeyContext, cipherBundle, request, size,
                     streamingV4Params, backendInfo, log, next);
         },
@@ -280,10 +282,12 @@ function createAndStoreObject(bucketName, bucketMD, objectKey, objMD, authInfo,
                 const options = overwritingVersioning(objMD, metadataStoreParams);
                 return process.nextTick(() => next(null, options, infoArr));
             }
+
             if (!bucketMD.isVersioningEnabled() && objMD?.archive?.archiveInfo) {
                 // Ensure we trigger a "delete" event in the oplog for the previously archived object
                 metadataStoreParams.needOplogUpdate = 's3:ReplaceArchivedObject';
             }
+
             return versioningPreprocessing(bucketName, bucketMD,
                 metadataStoreParams.objectKey, objMD, log, (err, options) => {
                     if (err) {
@@ -316,9 +320,11 @@ function createAndStoreObject(bucketName, bucketMD, objectKey, objMD, authInfo,
             metadataStoreParams.versioning = options.versioning;
             metadataStoreParams.isNull = options.isNull;
             metadataStoreParams.deleteNullKey = options.deleteNullKey;
+
             if (options.extraMD) {
                 Object.assign(metadataStoreParams, options.extraMD);
             }
+
             return _storeInMDandDeleteData(bucketName, infoArr,
                 cipherBundle, metadataStoreParams,
                 options.dataToDelete, log, requestMethod, next);

lib/api/apiUtils/object/versioning.js

@@ -329,14 +329,15 @@ function versioningPreprocessing(bucketName, bucketMD, objectKey, objMD,
     log, callback) {
     const mst = getMasterState(objMD);
     const vCfg = bucketMD.getVersioningConfiguration();
-    // bucket is not versioning configured
+
     if (!vCfg) {
         const options = { dataToDelete: mst.objLocation };
         return process.nextTick(callback, null, options);
     }
-    // bucket is versioning configured
+
     const { options, nullVersionId, delOptions } =
           processVersioningState(mst, vCfg.Status, config.nullVersionCompatMode);
+
     return async.series([
         function storeNullVersionMD(next) {
             if (!nullVersionId) {

lib/routes/routeBackbeat.js

@@ -39,6 +39,8 @@ const { listLifecycleNonCurrents } = require('../api/backbeat/listLifecycleNonCu
 const { listLifecycleOrphanDeleteMarkers } = require('../api/backbeat/listLifecycleOrphanDeleteMarkers');
 const { objectDeleteInternal } = require('../api/objectDelete');
 const quotaUtils = require('../api/apiUtils/quotas/quotaUtils');
+const { versioningPreprocessing }
+    = require('../api/apiUtils/object/versioning');
 
 const { CURRENT_TYPE, NON_CURRENT_TYPE, ORPHAN_DM_TYPE } = constants.lifecycleListing;
 
@@ -507,23 +509,22 @@ function putMetadata(request, response, bucketInfo, objMd, log, callback) {
         if (err) {
             return callback(err);
         }
+
         let omVal;
+
         try {
             omVal = JSON.parse(payload);
         } catch {
-            // FIXME: add error type MalformedJSON
             return callback(errors.MalformedPOSTRequest);
         }
+
         const { headers, bucketName, objectKey } = request;
-        // check if it's metadata only operation
+
         if (headers['x-scal-replication-content'] === 'METADATA') {
             if (!objMd) {
-                // if the target does not exist, return an error to
-                // backbeat, who will have to retry the operation as a
-                // complete replication
                 return callback(errors.ObjNotFound);
             }
-            // use original data locations and encryption info
+
             [
                 'location',
                 'x-amz-server-side-encryption',
@@ -629,6 +630,7 @@ function putMetadata(request, response, bucketInfo, objMd, log, callback) {
         }
 
         return async.series([
+            next => versioningPreprocessing(bucketName, bucketInfo, objectKey, objMd, log, next),
             // Zenko's CRR delegates replacing the account
             // information to the destination's Cloudserver, as
             // Vault admin APIs are not exposed externally.