fixups post reviews

Author: benzekrimaha

tests/functional/aws-node-sdk/test/bucket/deleteBucketLifecycle.js

@@ -47,7 +47,6 @@ describe('aws-sdk test delete bucket lifecycle', () => {
     it('should return NoSuchBucket error if bucket does not exist', async () => {
         try {
             await s3.send(new DeleteBucketLifecycleCommand({ Bucket: bucket }));
-            // Should not reach here
             throw new Error('Expected NoSuchBucket error');
         } catch (err) {
             assertError(err, 'NoSuchBucket');
@@ -62,7 +61,6 @@ describe('aws-sdk test delete bucket lifecycle', () => {
         it('should return AccessDenied if user is not bucket owner', async () => {
             try {
                 await otherAccountS3.send(new DeleteBucketLifecycleCommand({ Bucket: bucket }));
-                // Should not reach here
                 throw new Error('Expected AccessDenied error');
             } catch (err) {
                 assertError(err, 'AccessDenied');

tests/functional/aws-node-sdk/test/bucket/getLocation.js

@@ -20,8 +20,10 @@ async function deleteBucket(s3, bucket) {
     try {
         await s3.send(new DeleteBucketCommand({ Bucket: bucket }));
     } catch (err) {
-        // eslint-disable-next-line no-console
-        console.log(err);
+        if (err?.name === 'NoSuchBucket') {
+            return;
+        }
+        throw err;
     }
 }
 

tests/functional/aws-node-sdk/test/bucket/skipScan.js

@@ -15,26 +15,26 @@ function cutAttributes(data) {
         data.Contents.forEach(item => {
             newContent.push(item.Key);
         });
-        /* eslint-disable no-param-reassign */
+        /* eslint-disable-next-line no-param-reassign */
         data.Contents = newContent;
     }
     if (data.CommonPrefixes) {
         data.CommonPrefixes.forEach(item => {
             newPrefixes.push(item.Prefix);
         });
-        /* eslint-disable no-param-reassign */
+        /* eslint-disable-next-line no-param-reassign */
         data.CommonPrefixes = newPrefixes;
     }
     if (data.NextMarker === '') {
-        /* eslint-disable no-param-reassign */
+        /* eslint-disable-next-line no-param-reassign */
         delete data.NextMarker;
     }
     if (data.EncodingType === '') {
-        /* eslint-disable no-param-reassign */
+        /* eslint-disable-next-line no-param-reassign */
         delete data.EncodingType;
     }
     if (data.Delimiter === '') {
-        /* eslint-disable no-param-reassign */
+        /* eslint-disable-next-line no-param-reassign */
         delete data.Delimiter;
     }
 }