✨ check that backend support versioning

Author: DarkIsDude

lib/routes/routeBackbeat.js

@@ -543,6 +543,18 @@ function putMetadata(request, response, bucketInfo, objMd, log, callback) {
         let versionId = decodeVersionId(request.query);
         let versioning = bucketInfo.isVersioningEnabled();
         let isNull = false;
+        const storageType = headers['x-scal-storage-type'];
+        let versioningNotImpl = false;
+        console.info('storage type', { storageType, versioningNotImplBackends: constants.versioningNotImplBackends });
+
+        if (constants.versioningNotImplBackends[storageType]) {
+            log.debug(
+                'versioning is not implemented on the destination backend',
+                { method: 'putMetadata', error: errors.NotImplemented },
+            );
+
+            versioningNotImpl = true;
+        }
 
         if (versionId === 'null') {
             isNull = true;
@@ -616,10 +628,13 @@ function putMetadata(request, response, bucketInfo, objMd, log, callback) {
         // To prevent this, the versionId field is only included in options when it is defined.
         if (versionId !== undefined) {
             options.versionId = versionId;
-            omVal.versionId = versionId;
 
-            if (isNull) {
-                omVal.isNull = isNull;
+            if (!versioningNotImpl) {
+                omVal.versionId = versionId;
+
+                if (isNull) {
+                    omVal.isNull = isNull;
+                }
             }
 
             // In the MongoDB metadata backend, setting the versionId option leads to the creation
@@ -663,21 +678,24 @@ function putMetadata(request, response, bucketInfo, objMd, log, callback) {
                 });
             },
             async () => {
-                if (versioning && !objMd) {
-                    const masterObjectAndBucket =
-                        await metadata.getBucketAndObjectMDPromised(bucketName, objectKey, {}, log);
+                if (!versioning || objMd || versioningNotImpl) {
+                    console.info('skipping versioning preprocessing', { versioning, hasObjMd: !!objMd });
+                    return;
+                }
 
-                    if (!masterObjectAndBucket.obj) {
-                        return;
-                    }
+                const masterObjectAndBucket =
+                    await metadata.getBucketAndObjectMDPromised(bucketName, objectKey, {}, log);
 
-                    const masterObject = JSON.parse(masterObjectAndBucket.obj);
-                    const versioningPreprocessingResult =
-                        await versioningPreprocessingPromised(bucketName, bucketInfo, objectKey, masterObject, log);
+                if (!masterObjectAndBucket.obj) {
+                    return;
+                }
 
-                    if (versioningPreprocessingResult?.nullVersionId) {
-                        omVal.nullVersionId = versioningPreprocessingResult.nullVersionId;
-                    }
+                const masterObject = JSON.parse(masterObjectAndBucket.obj);
+                const versioningPreprocessingResult =
+                    await versioningPreprocessingPromised(bucketName, bucketInfo, objectKey, masterObject, log);
+
+                if (versioningPreprocessingResult?.nullVersionId) {
+                    omVal.nullVersionId = versioningPreprocessingResult.nullVersionId;
                 }
             },
             next => {

tests/multipleBackend/routes/routeBackbeat.js

@@ -2467,14 +2467,18 @@ describe('backbeat routes', () => {
             ], done);
         });
 
-        it('should put tags if the source is Azure and tags are provided ' +
+        it.only('should put tags if the source is Azure and tags are provided ' +
         'when completing the multipart upload', done => {
             const containerName = getAzureContainerName(azureLocation);
             const blob = uuidv4();
             const multipleBackendPath =
                 `/_/backbeat/multiplebackenddata/${containerName}/${blob}`;
             const uploadId = uuidv4().replace(/-/g, '');
             let partData;
+
+            console.info(`Azure container name: ${containerName}`);
+            console.info({ azureLocation });
+
             async.series([
                 next =>
                     makeRequest({
@@ -2525,10 +2529,20 @@ describe('backbeat routes', () => {
                 next =>
                     azureClient.getContainerClient(containerName).getBlobClient(blob).getProperties()
                         .then(result => {
+                            console.info('got blob properties', { result });
                             const tags = JSON.parse(result.metadata.tags);
                             assert.deepStrictEqual(tags, { key1: 'value1' });
                             return next();
-                        }, next),
+                        }, err => {
+                            console.error({ err });
+                            console.error('error getting blob properties 1');
+                            next;
+                        })
+                        .catch(err => {
+                            console.error({ err });
+                            console.error('error getting blob properties 2', err);
+                            return next(err);
+                        }),
             ], done);
         });
     });