fixups post reviews

Author: benzekrimaha

tests/functional/aws-node-sdk/test/object/bigMpu.js

@@ -61,7 +61,6 @@ describe('large mpu', function tester() {
         // another request after first request has already deleted parts,
         // causing InvalidPart. Meanwhile, if request takes too long to finish,
         // sdk will create SocketHangUp error before response.
-        // Custom request handler with no timeouts
         const requestHandler = new NodeHttpHandler({
             requestTimeout: 0,
             connectionTimeout: 0,
@@ -94,19 +93,17 @@ describe('large mpu', function tester() {
     itSkipIfAWS('should intiate, put parts and complete mpu ' +
         `with ${partCount} parts`, done => {
         process.stdout.write('***Running large MPU test***\n');
-        let uploadId;     
+        let uploadId;
         return waterfall([
             next => {
                 s3.send(new CreateMultipartUploadCommand({ Bucket: bucket, Key: key }))
                     .then(data => {
-                        process.stdout.write('initiated mpu\n');
                         uploadId = data.UploadId;
                         return next();
                     })
                     .catch(err => next(err));
             },
             next => {
-                process.stdout.write('putting parts\n');
                 return timesLimit(partCount, 20, (n, cb) =>
                     uploadPart(n, uploadId, s3, cb), err => {
                         if (err) {
@@ -135,19 +132,14 @@ describe('large mpu', function tester() {
                     },
                 };
                 return s3.send(new CompleteMultipartUploadCommand(params))
-                    .then(() => {
-                        process.stdout.write('mpu completed successfully\n');
-                        next();
-                    })
+                    .then(() => next())
                     .catch(err => next(err));
             },
             next => {
-                process.stdout.write('about to get object\n');
                 s3.send(new GetObjectCommand({ Bucket: bucket, Key: key }))
                     .then(data => {
                         assert.strictEqual(data.ETag,
                                 `"${finalETag}-${partCount}"`);
-                        process.stdout.write('get object successful\n');
                         return next();
                     })
                     .catch(err => next(err));

tests/functional/aws-node-sdk/test/object/getObjectLegalHold.js

@@ -104,7 +104,8 @@ describeSkipIfCeph('GET object legal hold', () => {
                     throw new Error('Expected NoSuchKey error');
                 }).catch(err => {
                     checkError(err, 'NoSuchKey', 404);
-                })).catch(err => {
+                })
+            ).catch(err => {
                 assert.ifError(err);
             })
         );

tests/functional/aws-node-sdk/test/object/getPartSize.js

@@ -59,18 +59,12 @@ describe('Part size tests with object head', () => {
         before(async () => {
             bucketUtil = new BucketUtility('default', sigCfg);
             s3 = bucketUtil.s3;
-
-            // Create bucket
             await s3.send(new CreateBucketCommand({ Bucket: bucket }));
-
-            // Create multipart upload
             const uploadResult = await s3.send(new CreateMultipartUploadCommand({
                 Bucket: bucket,
                 Key: object
             }));
             uploadId = uploadResult.UploadId;
-
-            // Upload parts
             const uploadPromises = partNumbers.map(async partNumber => {
                 const uploadPartParams = {
                     Bucket: bucket,
@@ -82,24 +76,17 @@ describe('Part size tests with object head', () => {
                 const result = await s3.send(new UploadPartCommand(uploadPartParams));
                 return result.ETag;
             });
-
             ETags = await Promise.all(uploadPromises);
-
-            // Put empty object
             await s3.send(new PutObjectCommand({
                 Bucket: bucket,
                 Key: emptyObject,
                 Body: '',
             }));
-
-            // Put non-MPU object
             await s3.send(new PutObjectCommand({
                 Bucket: bucket,
                 Key: nonMpuObject,
                 Body: generateContent(0),
             }));
-
-            // Complete multipart upload
             const completeParams = {
                 Bucket: bucket,
                 Key: object,

tests/functional/aws-node-sdk/test/object/mpu.js

@@ -1,4 +1,3 @@
-
 const assert = require('assert');
 const {
     CreateBucketCommand,