Skip to content

Commit 1a54a1c

Browse files
fix: address review comments on metrics cert watcher log and changelog
- Fix setupLog.Error call: add "Failed" prefix and remove duplicate err parameter in both operator/cmd/main.go and storage-operator/cmd/main.go - Remove incorrect Go version mention (1.24.13) from CHANGELOG entry
1 parent 1708181 commit 1a54a1c

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

CHANGELOG.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,7 @@
5858
(PR[#4824](https://github.com/scality/metalk8s/pull/4824))
5959

6060
- Bump `operator-sdk` version to [1.42.1](https://github.com/operator-framework/operator-sdk/releases/tag/v1.42.1)
61-
in `metalk8s-operator` and `storage-operator`.
62-
Go version has been bumped to
63-
[1.24.13](https://golang.org/doc/devel/release.html#go1.24.minor)
61+
in `metalk8s-operator` and `storage-operator`
6462
(PR[#4818](https://github.com/scality/metalk8s/pull/4818))
6563

6664
- Implement ability to add certificates to fluent-bit by mounting a fluent-bit-certs secret

operator/cmd/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ func main() {
169169
filepath.Join(metricsCertPath, metricsCertKey),
170170
)
171171
if err != nil {
172-
setupLog.Error(err, "to initialize metrics certificate watcher", "error", err)
172+
setupLog.Error(err, "Failed to initialize metrics certificate watcher")
173173
os.Exit(1)
174174
}
175175

storage-operator/cmd/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ func main() {
169169
filepath.Join(metricsCertPath, metricsCertKey),
170170
)
171171
if err != nil {
172-
setupLog.Error(err, "to initialize metrics certificate watcher", "error", err)
172+
setupLog.Error(err, "Failed to initialize metrics certificate watcher")
173173
os.Exit(1)
174174
}
175175

0 commit comments

Comments
 (0)