Skip to content

Commit 2357b0e

Browse files
fix(review-pr): correct OR/AND precedence in unjustified_dismissal condition
As written, the condition read: (resolved with no reply) OR (dismissive reply AND code unchanged). This meant if someone fixed the code and resolved the thread without commenting, Claude would still challenge them. Fix: add parentheses so the code-unchanged guard applies to both branches: (resolved with no reply OR dismissive reply) AND code unchanged in new diff Caught by claude[bot] review on scality/agent-hub#26. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
1 parent 761dfe9 commit 2357b0e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.claude/skills/review-pr/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ gh pr diff <number> --repo <owner/repo>
6060

6161
- **`justified`** — human reply contains substantive technical reasoning (why issue isn't applicable, acknowledged trade-off, relevant constraint) → accept silently. Add to SKIP SET. Optionally resolve thread if still open.
6262
63-
- **`unjustified_dismissal`** — thread resolved by human with no reply, OR reply is dismissive with no technical reasoning (`"done"`, `"ok"`, `"wontfix"` with nothing substantive) AND flagged code still unchanged in new diff → reply in thread (do NOT post new top-level comment). Add to SKIP SET.
63+
- **`unjustified_dismissal`** — (thread resolved by human with no reply, OR reply is dismissive with no technical reasoning (`"done"`, `"ok"`, `"wontfix"` with nothing substantive)) AND flagged code still unchanged in new diff → reply in thread (do NOT post new top-level comment). Add to SKIP SET.
6464
```bash
6565
gh api -X POST -H "Accept: application/vnd.github+json" "repos/<owner/repo>/pulls/<number>/comments" -f body="Issue still present in latest commit. Could you share your reasoning or clarify how it's been mitigated?<br><br>— Claude Code" -F in_reply_to=<databaseId_of_first_comment> -f commit_id="<headRefOid>"
6666
```

0 commit comments

Comments
 (0)