salt: Remove cri.execute salt module function

This salt execution module is not used so let's remove it

Author: TeddyAndrieux

salt/_modules/cri.py

@@ -99,48 +99,6 @@ def pull_image(image):
     return ret
 
 
-def execute(name, command, *args):
-    """
-    Run a command in a container.
-
-    .. note::
-
-       This uses the :command:`crictl` command, which should be configured
-       correctly on the system, e.g. in :file:`/etc/crictl.yaml`.
-
-    name
-        Name of the target container
-    command
-        Command to run
-    args
-        Command parameters
-    """
-    log.info('Retrieving ID of container "%s"', name)
-    out = __salt__["cmd.run_all"](
-        f'crictl ps -q --label io.kubernetes.container.name="{name}"'
-    )
-
-    if out["retcode"] != 0:
-        log.error('Failed to find container "%s"', name)
-        return None
-
-    container_id = out["stdout"]
-    if not container_id:
-        log.error('Container "%s" does not exists', name)
-        return None
-
-    cmd_opts = f"{command} {' '.join(args)}"
-
-    log.info('Executing command "%s"', cmd_opts)
-    out = __salt__["cmd.run_all"](f"crictl exec {container_id} {cmd_opts}")
-
-    if out["retcode"] != 0:
-        log.error('Failed run command "%s"', cmd_opts)
-        return None
-
-    return out["stdout"]
-
-
 def wait_container(name, state, timeout=60, delay=5):
     """
     Wait for a container to be in given state.

salt/tests/unit/modules/test_cri.py

@@ -157,40 +157,6 @@ def test_pull_image(self, retcode, stdout, result):
             self.assertEqual(cri.pull_image("my-images"), result)
             mock_cmd.assert_called_once_with('crictl pull "my-images"')
 
-    @parameterized.expand(
-        [
-            (0, "292c3b07b", 0, "All ok", "All ok"),
-            (1, "292c3b07b", 0, "All ok", None),
-            (0, "", 0, "All ok", None),
-            (0, "292c3b07b", 1, "All not ok", None),
-            (0, "292c3b07b", 0, "", ""),
-        ]
-    )
-    def test_execute(self, ret_ps, stdout_ps, ret_exec, stdout_exec, result):
-        """
-        Tests the return of `execute` function
-        """
-        cmd_ps = utils.cmd_output(retcode=ret_ps, stdout=stdout_ps)
-        cmd_exec = utils.cmd_output(retcode=ret_exec, stdout=stdout_exec)
-
-        def _cmd_run_all_mock(cmd):
-            if "crictl ps" in cmd:
-                return cmd_ps
-            elif "crictl exec" in cmd:
-                return cmd_exec
-            return None
-
-        mock_cmd = MagicMock(side_effect=_cmd_run_all_mock)
-        with patch.dict(cri.__salt__, {"cmd.run_all": mock_cmd}):
-            self.assertEqual(cri.execute("my_cont", "my command"), result)
-            mock_cmd.assert_any_call(
-                'crictl ps -q --label io.kubernetes.container.name="my_cont"'
-            )
-            if ret_ps == 0 and stdout_ps:
-                mock_cmd.assert_called_with(
-                    "crictl exec {} my command ".format(stdout_ps)
-                )
-
     @parameterized.expand(
         [
             # Success: Found one container