Skip to content

Commit f93f947

Browse files
ChengYanJing-carre
andauthored
Update .claude/skills/review-pr/SKILL.md
Co-authored-by: Guillaume CARRE <122804551+g-carre@users.noreply.github.com>
1 parent 1db1d14 commit f93f947

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.claude/skills/review-pr/SKILL.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ gh pr diff <number> --repo <owner/repo>
4848
| Salt states | Correct use of requisites (`require`, `watch`, `onchanges`); no hardcoded credentials; proper Jinja templating |
4949
| Helm/Kustomize | Resource limits set, security contexts defined, proper label selectors, upgrade path preserved |
5050
| Python | No bare `except:`; specific exception types; type hints on new functions; no blocking calls in async context |
51+
| Python / buildchain | Correct doit task dependencies and file targets; proper pytest fixtures; behave step definitions match feature files; no hardcoded paths (use constants.py) |
5152
| Security | No secrets/tokens in plain text; no OWASP-relevant issues (injection, XSS, insecure defaults) |
5253
| Breaking changes | Public API changes, CRD schema changes, Salt pillar schema changes, UI prop interface changes |
5354

0 commit comments

Comments
 (0)