✨ add pre-commit and pyenv

Author: Yoan Moscatelli

.devcontainer/Dockerfile

@@ -1,4 +1,4 @@
-FROM mcr.microsoft.com/devcontainers/base:jammy
+FROM mcr.microsoft.com/devcontainers/base:noble
 
 RUN export DEBIAN_FRONTEND=noninteractive && \
     apt-get update && \
@@ -8,14 +8,33 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
         bash-completion \
         curl \
         git \
+        libsqlite3-dev \
         python3-pip \
         p7zip-full \
         skopeo \
         tmux \
         vim \
         && \
     apt-get clean
+
+USER vscode
+
+ENV LANG=C.UTF-8
+ENV LC_ALL=C.UTF-8
+
+ENV PYENV_ROOT="/usr/local/pyenv"
+ENV PATH="$PYENV_ROOT/shims:$PYENV_ROOT/bin:$PATH"
+
 COPY requirements.txt /tmp/requirements.txt
-RUN python3 -m pip install --no-cache-dir --upgrade pip && \
-    python3 -m pip install --no-cache-dir -r /tmp/requirements.txt
-USER vscode
+
+# Install pyenv
+RUN sudo git clone https://github.com/pyenv/pyenv.git $PYENV_ROOT && \
+    sudo chown $(id -u):$(id -g) -R $PYENV_ROOT && \
+    printf 'export PYENV_ROOT=%s\nexport PATH="$PYENV_ROOT/shims:$PYENV_ROOT/bin:$PATH"\nif command -v pyenv 1>/dev/null 2>&1; then\n eval "$(pyenv init -)"\nfi\n' $PYENV_ROOT | sudo tee -a /etc/bash.bashrc -a /etc/zsh/zshrc
+
+# Install pythons
+RUN pyenv install 3.13.2 && \
+    pyenv global 3.13.2
+
+# Install python libs
+RUN pyenv exec pip install -r /tmp/requirements.txt

.devcontainer/requirements.txt

@@ -1,4 +1,5 @@
-requests==2.32.0
-GitPython==3.1.43
+requests==2.32.3
+GitPython==3.1.44
 pyunpack==0.3
-patool==2.2.0
+patool==4.0.0
+pre-commit==4.1.0

.devcontainer/setup.sh

@@ -2,7 +2,7 @@
 
 set -xe
 
-if [ "$CODESPACES" = "true" ]; then
+if [[ ${CODESPACES} = "true" ]]; then
   # NOTE: This is the only way I managed to have the right
   # permissions files for git sources files
   # (Some salt pylint test check file permissions and expected 644
@@ -25,4 +25,8 @@ gh extension install https://github.com/nektos/gh-act
 # Install dependencies
 echo "Installing dependencies"
 python3 src/main.py install
+
+echo "Install pre-commit hooks"
+pre-commit install --install-hooks
+
 echo "End of setup"

.github/dependabot.yml

@@ -12,9 +12,6 @@ updates:
     schedule:
       interval: "daily"
     rebase-strategy: "auto"
-    ignore:
-      - dependency-name: "requests"
-        versions: ["<2.25.1"]
     reviewers:
       - "scality/metalk8s"
 

.github/scripts/update_scanners.py

@@ -1,3 +1,5 @@
+#!/usr/bin/env python3
+
 import re
 import requests
 

.github/workflows/nightly.yaml

@@ -38,15 +38,23 @@ jobs:
       - name: Update scanner versions
         run: python .github/scripts/update_scanners.py
 
-      - name: Create Pull Request
-        uses: peter-evans/create-pull-request@v7
-        id: pr
-        with:
-          title: Dependency update
-          branch: feature/deps-update
-          delete-branch: true
-          commit-message: ":arrow_up: Update scanner versions"
-          token: ${{ steps.app-token.outputs.token }}
+      - name: Create pull request  
+        uses: actions/github-script@v7  
+        with:  
+          script: |
+            const pr = await github.rest.pulls.create({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              head: "feature/deps-update",
+              base: "main",
+              title: ":arrow_up: Update scanner versions"
+            });  
+
+            await github.rest.issues.createComment({
+              issue_number: pr.data.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo
+            })
 
   vuln-scan:
     permissions:
@@ -58,7 +66,6 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
         with:
-          path: ./
           fetch-depth: 0
           fetch-tags: true
 

.pre-commit-config.yaml

@@ -0,0 +1,27 @@
+default_language_version:
+  python: python3.12
+
+repos:
+  - repo: https://github.com/psf/black
+    rev: 25.1.0
+    hooks:
+      - id: black
+        files: src/.*\.py
+        name: Formatting Python
+      - id: black
+        files: src/.*\.py
+        # We want this hook to be part of "lint" so that if we run
+        # `pre-commit run lint` we include this hook
+        alias: lint
+        name: Checking Python formatting
+        args:
+          - --check
+          - --diff
+
+  - repo: https://github.com/pycqa/pylint
+    rev: v3.3.5
+    hooks:
+      - id: pylint
+        alias: lint
+        name: Lint Python (CLI)
+        files: src/.*\.py