Fix undefined 'equals' reference when registering watchers with

equality set to true.

Author: czerwingithub

scalyr.js

@@ -784,7 +784,7 @@ defineScalyrAngularModule('gatedScope', [])
               // circuit it with === operator, only when === fails do we use .equals
               if (watch && (value = watch.get(current)) !== (last = watch.last) &&
                   !(watch.eq
-                      ? equals(value, last)
+                      ? areEqual(value, last)
                       : (typeof value == 'number' && typeof last == 'number'
                         && isNaN(value) && isNaN(last)))) {
                 dirty = true;

src/js/lib/gatedScope.js

@@ -86,7 +86,7 @@ defineScalyrAngularModule('gatedScope', [])
               // circuit it with === operator, only when === fails do we use .equals
               if (watch && (value = watch.get(current)) !== (last = watch.last) &&
                   !(watch.eq
-                      ? equals(value, last)
+                      ? areEqual(value, last)
                       : (typeof value == 'number' && typeof last == 'number'
                         && isNaN(value) && isNaN(last)))) {
                 dirty = true;

src/tests/lib/gatedScopeTest.js

@@ -256,4 +256,26 @@ describe('GatedScope', function() {
     $rootScope.$digest();
     expect(counter).toEqual(4);
   });
+
+  it('should evaluate watchers registered with equality equal to true', function() {
+    var objectToWatch = { value: 5 };
+
+    var counter = 0;
+    function watcher() {
+      ++counter;
+      return objectToWatch;
+    }
+
+    // Add a gate so that all future watchers are evaluated using our version of $digest.
+    var scope = $rootScope.$new();
+    scope.$addWatcherGate(function() {
+      return true;
+    });
+
+    scope.$watch(watcher, function(newValue) {
+    }, true);
+
+    // When both gates are down, the watcher should not be evaluated.
+    $rootScope.$digest();
+  });
 });