DPDV-6415: Remove SIGSEV (#100)

* DPDV-6415: Remove SIGSEV

* Improve Finish go routine

* Fix few more tests

* Add more logging related to locks in Memo

* add_events_long_running_test are succeeding!!!

* All tests are passing now

* Add timeout restrictions so that it doesn't run for 6 hours

* Enable skipped buffer tests

* Reset tickers when event is received

* Fix test

* Add logging to the pub method

* Add even more logging

* Add even more logging

* Build and run commands with -race flag

* Also use channel for publishing messages

* Remove pubsub library

* Increase time interval between purges

* Move SessionManager to separate module

* Update buffer_config tests

* Add tests related to the buffer

* Add more buffer tests

* Make number of parallel buffer sendings configurable.

* Simplify SessionManager

* Add tests for SessionManager

* Bump version

* Fix session_manager tests

* Add sleep to make sure that everything is processed

* Reduce logging in the client

* Add more tests for statistics

* Remove unused variable publishAsap

* Make number of outgoing connections configurable

* Shutdown sequence finishes on time

* Incorporates comments from CR

* Improve some function names

* Incorporate comments from CR

* Rename private functions in the session manager

* To be safe stop tickers

Author: martin-majlis-s1

.github/workflows/code-quality.yaml

@@ -65,6 +65,7 @@ jobs:
         run: |
           pre-commit run -a
       - name: Code coverage
+        timeout-minutes: 15
         run: |
           make coverage
       - name: Upload coverage reports to Codecov
@@ -77,5 +78,6 @@ jobs:
         run: |
           make build-examples
       - name: Check SSL Certificates
+        timeout-minutes: 10
         run: |
           make test-ssl-certificates

.github/workflows/stress-tests.yaml

@@ -36,6 +36,7 @@ jobs:
         go: ['1.21', '1.22']
         os: [ubuntu-latest, windows-latest, macos-latest]
     runs-on: ${{ matrix.os }}
+    timeout-minutes: 15
     needs: pre_job
     if: ${{ needs.pre_job.outputs.should_skip != 'true' || github.ref_name == 'main' }}
 

.github/workflows/unit-tests.yaml

@@ -56,9 +56,11 @@ jobs:
         run: |
           go mod vendor
       - name: Code tests
+        timeout-minutes: 15
         run: |
           make test
       - name: Run Tests Many Times
+        timeout-minutes: 30
         # Run test multiple times to check for flaky tests
         if: github.ref_name == 'main'
         run: |

Makefile

@@ -24,7 +24,7 @@ endif
 
 GO_BUILD_TAGS=""
 GOTEST_OPT?= -v -race -timeout 300s -parallel 4 -count=1 --tags=$(GO_BUILD_TAGS)
-GOTEST_LONG_RUNNING_OPT?= -v -race -timeout 1200s -parallel 4 -count=1 -tags=long_running,$(GO_BUILD_TAGS)
+GOTEST_LONG_RUNNING_OPT?= -v -race -timeout 600s -parallel 4 -count=1 -tags=long_running,$(GO_BUILD_TAGS)
 GOTEST_OPT_WITH_COVERAGE = $(GOTEST_OPT) -coverprofile=coverage.txt -covermode=atomic
 GOTEST_OPT_WITH_COVERAGE_LONG_RUNNING=$(GOTEST_LONG_RUNNING_OPT) -coverprofile=coverage.txt -covermode=atomic
 GOCMD?= go
@@ -93,7 +93,7 @@ coverage-all:
 build-examples:
 	for d in examples/*; do \
   		echo "Build example: $${d}"; \
-		(cd $${d}; go mod tidy && go build) || exit 1; \
+		(cd $${d}; go mod tidy && go build -race) || exit 1; \
 	done;
 
 .PHONY: test-ssl-certificates

RELEASE_NOTES.md

@@ -1,5 +1,10 @@
 # Release Notes
 
+## 0.20.0
+
+* fix: fix SIGSEV that was caused by releasing resources associated with inactive sessions
+* feat: make number of parallel outgoing requests configurable
+
 ## 0.19.0
 
 * fix: retry also when server is not returning JSON

examples/client/go.mod

@@ -10,7 +10,6 @@ require (
 
 require (
 	github.com/cenkalti/backoff/v4 v4.3.0 // indirect
-	github.com/cskr/pubsub v1.0.2 // indirect
 	github.com/go-logr/logr v1.4.1 // indirect
 	github.com/go-logr/stdr v1.2.2 // indirect
 	github.com/google/uuid v1.6.0 // indirect

examples/client/go.sum

@@ -1,7 +1,5 @@
 github.com/cenkalti/backoff/v4 v4.3.0 h1:MyRJ/UdXutAwSAT+s3wNd7MfTIcy71VQueUuFK343L8=
 github.com/cenkalti/backoff/v4 v4.3.0/go.mod h1:Y3VNntkOUPxTVeUxJ/G5vcM//AlwfmyYozVcomhLiZE=
-github.com/cskr/pubsub v1.0.2 h1:vlOzMhl6PFn60gRlTQQsIfVwaPB/B/8MziK8FhEPt/0=
-github.com/cskr/pubsub v1.0.2/go.mod h1:/8MzYXk/NJAz782G8RPkFzXTZVu63VotefPnR9TIRis=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/go-logr/logr v1.2.2/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=

examples/readme/go.mod

@@ -10,7 +10,6 @@ require (
 
 require (
 	github.com/cenkalti/backoff/v4 v4.3.0 // indirect
-	github.com/cskr/pubsub v1.0.2 // indirect
 	github.com/go-logr/logr v1.4.1 // indirect
 	github.com/go-logr/stdr v1.2.2 // indirect
 	github.com/google/uuid v1.6.0 // indirect

examples/readme/go.sum

@@ -1,7 +1,5 @@
 github.com/cenkalti/backoff/v4 v4.3.0 h1:MyRJ/UdXutAwSAT+s3wNd7MfTIcy71VQueUuFK343L8=
 github.com/cenkalti/backoff/v4 v4.3.0/go.mod h1:Y3VNntkOUPxTVeUxJ/G5vcM//AlwfmyYozVcomhLiZE=
-github.com/cskr/pubsub v1.0.2 h1:vlOzMhl6PFn60gRlTQQsIfVwaPB/B/8MziK8FhEPt/0=
-github.com/cskr/pubsub v1.0.2/go.mod h1:/8MzYXk/NJAz782G8RPkFzXTZVu63VotefPnR9TIRis=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/go-logr/logr v1.2.2/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=

examples/stress/go.mod

@@ -9,7 +9,6 @@ require (
 
 require (
 	github.com/cenkalti/backoff/v4 v4.3.0 // indirect
-	github.com/cskr/pubsub v1.0.2 // indirect
 	github.com/google/uuid v1.6.0 // indirect
 	go.opentelemetry.io/otel v1.27.0 // indirect
 	go.opentelemetry.io/otel/metric v1.27.0 // indirect