Modified TestLiveQueryDataPlot to work with inactive accounts

Author: jmakar-s1

pkg/plugin/plugin.go

@@ -311,23 +311,14 @@ func (d *DataSetDatasource) CheckHealth(ctx context.Context, req *backend.CheckH
 		}, nil
 	}
 
+	// DataResponse.Error is set when the http status code is not 200
 	if dataResp.Error != nil {
 		return &backend.CheckHealthResult{
 			Status:  backend.HealthStatusError,
 			Message: "Failed to connect to DataSet: DataResponse.Error: " + dataResp.Error.Error(),
 		}, nil
 	}
 
-	// FIXME Look into upgrading to a later version and add a liveDataSource test
-	// NB At least for grafana-plugin-sdk-go v0.250.0, backend.DataResponse.Status is not set.
-	// Thankfully backend.DataResponse.Error is set when the http status code is not 200.
-	if dataResp.Status != backend.StatusUnknown && dataResp.Status != 0 && dataResp.Status != backend.StatusOK {
-		return &backend.CheckHealthResult{
-			Status:  backend.HealthStatusError,
-			Message: fmt.Sprintf("Failed to connect to DataSet: Received HTTP status code %d", dataResp.Status),
-		}, nil
-	}
-
 	return &backend.CheckHealthResult{
 		Status:  backend.HealthStatusOk,
 		Message: "Successfully connected to DataSet",

pkg/plugin/plugin_test.go

@@ -130,7 +130,7 @@ func TestLiveQueryDataPlot(t *testing.T) {
 					},
 					Interval:      1 * time.Minute,
 					MaxDataPoints: 1000,
-					JSON:          []byte(`{"expression":"count(severity != 3)","queryType":"Standard","breakDownFacetValue":"severity"}`),
+					JSON:          []byte(`{"expression":"count(serverHost='scalyr-metalog')","queryType":"Standard","breakDownFacetValue":"tag"}`),
 				},
 			},
 		},