-
Notifications
You must be signed in to change notification settings - Fork 0
Optional match stars revisions #343
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or requestfrontendRelated to the frontend applicationRelated to the frontend applicationrefactorRefactoring existing functionalityRefactoring existing functionalitytestingAdds a test or enhances testingAdds a test or enhances testing
Description
Great work on #299 @astep2023! The feature works and is good to ship. FYI @phodonou
Here is a list of feedback on optional changes you could make to improve the feature. You do not have to do these, since we want you to get on to your stretch project and do some work in Python. But just for your own learning.
- Instead of creating each button for the stars 1 - 5, render a list of elements so that less code is repeated, as explained in the intern handbook React tips
- Add a CSS style rule when hovering over a rating star or button to show
cursor: pointer, this helps the user know which elements are clickable - Currently, the Storybook tests do not load at all (see the screenshot below). The cause is because the hook
useCurrentAuthUser()requires Firebase to be initialized, but it is not initialized in Storybook. I realize now that we do not have to use the current user at all, there is a property on the chat datachat.forwhich gives you the user ID of the user who that chat was created for. If you pass in that value as youruserprop and remove the current user hook entirely, then your Storybook tests will load correctly.
Reactions are currently unavailable
Metadata
Metadata
Labels
enhancementNew feature or requestNew feature or requestfrontendRelated to the frontend applicationRelated to the frontend applicationrefactorRefactoring existing functionalityRefactoring existing functionalitytestingAdds a test or enhances testingAdds a test or enhances testing
