Skip to content

Optional match stars revisions #343

@vingkan

Description

@vingkan

Great work on #299 @astep2023! The feature works and is good to ship. FYI @phodonou

Here is a list of feedback on optional changes you could make to improve the feature. You do not have to do these, since we want you to get on to your stretch project and do some work in Python. But just for your own learning.

  • Instead of creating each button for the stars 1 - 5, render a list of elements so that less code is repeated, as explained in the intern handbook React tips
  • Add a CSS style rule when hovering over a rating star or button to show cursor: pointer, this helps the user know which elements are clickable
  • Currently, the Storybook tests do not load at all (see the screenshot below). The cause is because the hook useCurrentAuthUser() requires Firebase to be initialized, but it is not initialized in Storybook. I realize now that we do not have to use the current user at all, there is a property on the chat data chat.for which gives you the user ID of the user who that chat was created for. If you pass in that value as your user prop and remove the current user hook entirely, then your Storybook tests will load correctly.

Screen Shot 2022-07-27 at 8 45 19 PM

Metadata

Metadata

Labels

enhancementNew feature or requestfrontendRelated to the frontend applicationrefactorRefactoring existing functionalitytestingAdds a test or enhances testing

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions