|
if opt.startprob > 5 && maxiter < 8 % don't decrease and startover more than 8 times |
|
fprintf('Decreasing probability limits for final pruning...######\n'); |
|
opt.startprob = opt.startprob - 0.5; numrej = 1; maxiter = maxiter+1; % repeat process back to 5 stds |
|
else |
|
if maxiter > 8 |
|
opt.maxrej = 15; % go through last round with a high threshold |
|
else |
|
repeat = 0; |
|
end |
Dear EEGLab Team,
we are currently looking through the pop_autorej function because we are trying to imitate the process in python.
While doing so, we have run into a question regarding the trial rejection iteration flow.
We noticed that the maximum percentage of allowed rejected trials (opt.maxrej) is supposed to increase to 15 in line 216 for a final run through.
However, it is necessary that the variable maxiter increases to a minimum of 9 for this to happen.
maxiter is only increased in line 213, and due to the criterion in line 211, it can only ever reach a value of 8.
Unless we are missing something, we currently believe that this makes line 216 unreachable.
Furthermore, if it could be reached, subsequent runs would not be able to reach the break criterion in line 218 due to maxiter always being larger than 8.
We are now wondering if the increase of opt.maxrej is worth implementing at all, or if this is simply a piece of obsolete code that we should ignore.
We appreciate any help!
Kind Regards
eeglab/functions/popfunc/pop_autorej.m
Lines 211 to 219 in 4207693
Dear EEGLab Team,
we are currently looking through the pop_autorej function because we are trying to imitate the process in python.
While doing so, we have run into a question regarding the trial rejection iteration flow.
We noticed that the maximum percentage of allowed rejected trials (opt.maxrej) is supposed to increase to 15 in line 216 for a final run through.
However, it is necessary that the variable maxiter increases to a minimum of 9 for this to happen.
maxiter is only increased in line 213, and due to the criterion in line 211, it can only ever reach a value of 8.
Unless we are missing something, we currently believe that this makes line 216 unreachable.
Furthermore, if it could be reached, subsequent runs would not be able to reach the break criterion in line 218 due to maxiter always being larger than 8.
We are now wondering if the increase of opt.maxrej is worth implementing at all, or if this is simply a piece of obsolete code that we should ignore.
We appreciate any help!
Kind Regards