Skip to content

Commit 10be6be

Browse files
Add changelog entry for epic polish round
Summarizes the audit-driven fixes ahead of merge to dev: MLX variance_order, the doc corrections, and the new tracking issues (#312, #314, #315) plus the #306 extension.
1 parent bb405f4 commit 10be6be

1 file changed

Lines changed: 26 additions & 0 deletions

File tree

docs/changelog.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,32 @@ Release notes are also published on the
55

66
## Unreleased
77

8+
- **Epic #278 polish round: audit-driven fixes ahead of merge to `dev`.**
9+
`AMICAMLXNG` gained `variance_order` (issue #92), the EEGLAB
10+
back-projected-variance component order, closing the one accessor gap the
11+
epic's feature-parity audit found in an otherwise-complete Phase 3
12+
(validated on real data against a float64 `AMICATorchNG` twin holding
13+
identical fitted parameters: the component order matches exactly on a
14+
config with non-degenerate variance gaps). The audit also found several
15+
stale/misattributed doc claims, fixed here: `docs/guides/amica-differences.md`
16+
now attributes the degenerate-fit refusal to the `AMICA` wrapper rather than
17+
the raw PyTorch backend (the raw-backend gap is issue #306), and gained an
18+
"Unmapped Fortran keywords" section pointing to `fortran_params.py`'s
19+
`FORTRAN_UNSUPPORTED_KEYS` as the enumeration, naming three keywords dead in
20+
the reference itself (`filter_length`/`dft_length`/`decwindow`), and
21+
recording the `do_rho`-vs-`pdftype` divergence explicitly; `AGENTS.md` and
22+
`.context/progress_summary.md` no longer claim `validate_implementations.py`
23+
covers the NumPy/MLX backends (it is torch-vs-Fortran only; extending it is
24+
issue #315); `.context/feature_parity.md` and `.context/progress_summary.md`
25+
no longer claim the runtime-vs-Fortran benchmark is unmeasured or that issue
26+
#15 (save/load and `plot_components` test coverage) is open, both stale
27+
since earlier work landed; and `fortran_params.py`'s unsupported-keys table
28+
no longer claims `writestep`/`do_history`/`histstep` have no pamica
29+
equivalent -- they are implemented on the legacy NumPy backend, just not
30+
yet on torch/MLX (issue #312). Also aligned the legacy NumPy backend's
31+
inert `pdftype` constructor default to 0, matching torch/MLX (the value is
32+
never read, so this is a documentation-equivalent surface fix, not a
33+
behavior change).
834
- **MLX backend: outlier rejection, LLt stash, EEGLAB export, MIR/PMI**
935
(issue #289, epic #278 Phase 3 -- completes the epic). `AMICAMLXNG` gains:
1036
the LLt stash (issue #157), filled per-block by the E-step (never a second

0 commit comments

Comments
 (0)