Skip to content

Commit 87088fe

Browse files
Note keep_best now also covers AMICAMLXNG in ADR 0003
One-line addendum: the safeguard was ported to the MLX backend in epic #278 Phase 2 (issue #288), with the same default, tolerance, and share_comps/do_reject exclusions (PR #318 review item 17).
1 parent 5a7df3f commit 87088fe

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

.context/decisions/0003-best-iterate-safeguard.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,14 @@ changes across iterations and per-iteration LLs are not comparable.
6868
parameters from a diverged run, but entangles with issue #50's degenerate-fit
6969
contract; the safeguard is skipped for degenerate stops and left to #50.
7070

71+
## Addendum (epic #278 Phase 2, issue #288)
72+
73+
The safeguard now also governs `AMICAMLXNG`: same `keep_best` default, same
74+
`_KEEP_BEST_TOL`, and the same `share_comps`/`do_reject` exclusions (the
75+
latter joined in Phase 3, issue #289) -- see `pamica/mlx_impl/core.py`'s
76+
`_snapshot_params`/`_restore_params` and
77+
`pamica/tests/mlx_tests/test_mlx_keepbest.py`.
78+
7179
## Receipts
7280

7381
- `pamica/torch_impl/amica_torch_ng.py` (`keep_best`, `_snapshot_params`/

0 commit comments

Comments
 (0)