Use table type to find views (#2354)

Author: sualeh

schemacrawler-lint/src/main/java/schemacrawler/tools/linter/LinterProviderForeignKeyMismatch.java

@@ -9,7 +9,6 @@
 package schemacrawler.tools.linter;
 
 import static java.util.Objects.requireNonNull;
-import static schemacrawler.utility.MetaDataUtility.isView;
 
 import java.io.Serial;
 import java.sql.Connection;
@@ -64,7 +63,7 @@ protected void lint(final Table table, final Connection connections) {
 
   private List<ForeignKey> findMismatchedForeignKeys(final Table table) {
     final List<ForeignKey> mismatchedForeignKeys = new ArrayList<>();
-    if (table != null && !isView(table)) {
+    if (table != null && !table.getTableType().isView()) {
       for (final ForeignKey foreignKey : table.getImportedForeignKeys()) {
         for (final ColumnReference columnReference : foreignKey) {
           final Column pkColumn = columnReference.getPrimaryKeyColumn();

schemacrawler-lint/src/main/java/schemacrawler/tools/linter/LinterProviderTableAllNullableColumns.java

@@ -10,7 +10,6 @@
 
 import static java.util.Objects.requireNonNull;
 import static schemacrawler.ermodel.utility.ERModelUtility.inferBridgeTable;
-import static schemacrawler.utility.MetaDataUtility.isView;
 
 import java.io.Serial;
 import java.sql.Connection;
@@ -54,7 +53,7 @@ public String getSummary() {
   protected void lint(final Table table, final Connection connection) {
     requireNonNull(table, "No table provided");
 
-    if (isView(table) || inferBridgeTable(table) == OptionalBoolean.true_value) {
+    if (table.getTableType().isView() || inferBridgeTable(table) == OptionalBoolean.true_value) {
       return;
     }
 

schemacrawler-text/src/main/java/schemacrawler/tools/text/formatter/schema/SchemaTextFormatter.java

@@ -33,7 +33,6 @@
 import static schemacrawler.tools.command.text.schema.options.HideDependantDatabaseObjectsType.hideTableConstraints;
 import static schemacrawler.tools.command.text.schema.options.HideDependantDatabaseObjectsType.hideTriggers;
 import static schemacrawler.utility.MetaDataUtility.getTypeName;
-import static schemacrawler.utility.MetaDataUtility.isView;
 import static us.fatehi.utility.Utility.isBlank;
 import static us.fatehi.utility.Utility.trimToEmpty;
 
@@ -1221,23 +1220,21 @@ private void printTriggers(final Collection<Trigger> triggers) {
   }
 
   private void printViewTableUsage(final Table table) {
-    if (table == null || !isView(table)) {
-      return;
-    }
-    final View view = (View) table;
-    final Collection<Table> tableUsage = view.getTableUsage();
-    if (tableUsage.isEmpty()) {
-      return;
-    }
+    if (table instanceof final View view) {
+      final Collection<Table> tableUsage = view.getTableUsage();
+      if (tableUsage.isEmpty()) {
+        return;
+      }
 
-    formattingHelper.writeEmptyRow();
-    formattingHelper.writeWideRow("Table Usage", "section");
+      formattingHelper.writeEmptyRow();
+      formattingHelper.writeWideRow("Table Usage", "section");
 
-    formattingHelper.writeEmptyRow();
-    for (final Table usedTable : tableUsage) {
-      final String tableName = quoteName(usedTable);
-      final String tableType = "[" + usedTable.getTableType() + "]";
-      formattingHelper.writeNameRow(tableName, tableType);
+      formattingHelper.writeEmptyRow();
+      for (final Table usedTable : tableUsage) {
+        final String tableName = quoteName(usedTable);
+        final String tableType = "[" + usedTable.getTableType() + "]";
+        formattingHelper.writeNameRow(tableName, tableType);
+      }
     }
   }
 }