refactor: review commands

Author: deguif

Command/ExtractTranslationCommand.php

@@ -37,20 +37,11 @@
  */
 class ExtractTranslationCommand extends Command
 {
-    /**
-     * @var ConfigFactory
-     */
-    private $configFactory;
+    private ConfigFactory $configFactory;
 
-    /**
-     * @var Updater
-     */
-    private $updater;
+    private Updater $updater;
 
-    /**
-     * @var array
-     */
-    private $locales;
+    private array $locales;
 
     public function __construct(ConfigFactory $configFactory, Updater $updater, array $locales)
     {
@@ -82,7 +73,8 @@ protected function configure(): void
             ->addOption('intl-icu', null, InputOption::VALUE_NONE, 'Flag to indicate if translations should be dumped to using the ICU message format.')
             ->addOption('default-output-format', null, InputOption::VALUE_REQUIRED, 'The default output format (defaults to xlf).')
             ->addOption('keep', null, InputOption::VALUE_NONE, 'Define if the updater service should keep the old translation (defaults to false).')
-            ->addOption('external-translations-dir', null, InputOption::VALUE_IS_ARRAY | InputOption::VALUE_REQUIRED, 'Load external translation resources');
+            ->addOption('external-translations-dir', null, InputOption::VALUE_IS_ARRAY | InputOption::VALUE_REQUIRED, 'Load external translation resources')
+        ;
     }
 
     protected function execute(InputInterface $input, OutputInterface $output): int
@@ -142,18 +134,18 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                     }
                 }
 
-                return 0;
+                return Command::SUCCESS;
             }
 
             $this->updater->process($config);
         }
 
         $output->writeln('done!');
 
-        return 0;
+        return Command::SUCCESS;
     }
 
-    private function updateWithInput(InputInterface $input, ConfigBuilder $builder)
+    private function updateWithInput(InputInterface $input, ConfigBuilder $builder): void
     {
         if ($bundle = $input->getOption('bundle')) {
             if ('@' === $bundle[0]) {

Command/ResourcesListCommand.php

@@ -32,20 +32,14 @@
  */
 class ResourcesListCommand extends Command
 {
-    /**
-     * @var string
-     */
-    private $projectDir;
+    private string $projectDir;
 
     /**
      * @var string|null
      */
     private $rootDir;
 
-    /**
-     * @var array
-     */
-    private $bundles;
+    private array $bundles;
 
     public function __construct(string $projectDir, array $bundles, ?string $rootDir)
     {
@@ -61,7 +55,8 @@ protected function configure(): void
         $this
             ->setName('jms:translation:list-resources')
             ->setDescription('List translation resources available.')
-            ->addOption('files', null, InputOption::VALUE_OPTIONAL, 'Display only files');
+            ->addOption('files', null, InputOption::VALUE_OPTIONAL, 'Display only files')
+        ;
     }
 
     protected function execute(InputInterface $input, OutputInterface $output): int
@@ -88,7 +83,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
             $output->writeln('done!');
 
-            return 0;
+            return Command::SUCCESS;
         }
 
         $output->writeln('<info>Resources list :</info>');
@@ -102,15 +97,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         $output->writeln('done!');
 
-        return 0;
+        return Command::SUCCESS;
     }
 
-    /**
-     * @param array $dirs
-     *
-     * @return array
-     */
-    private function retrieveFiles(array $dirs)
+    private function retrieveFiles(array $dirs): array
     {
         $files = [];
         // Register translation resources
@@ -127,10 +117,8 @@ private function retrieveFiles(array $dirs)
 
     /**
      * The following methods is derived from code of the FrameworkExtension.php file from the Symfony2 framework
-     *
-     * @return array
      */
-    private function retrieveDirs()
+    private function retrieveDirs(): array
     {
         // Discover translation directories
         $dirs = [];