Merge pull request #600 from deguif/review-tests

Review tests

Author: goetas

Tests/DependencyInjection/Compiler/MountDumpersPassTest.php

@@ -23,7 +23,7 @@ protected function registerCompilerPass(ContainerBuilder $container): void
     /**
      * @test
      */
-    public function ifCompilerPassCollectsServicesByArgumentTheseWillExist()
+    public function ifCompilerPassCollectsServicesByArgumentTheseWillExist(): void
     {
         $collectingService = new Definition();
         $this->setDefinition('jms_translation.file_writer', $collectingService);

Tests/DependencyInjection/Compiler/MountExtractorsPassTest.php

@@ -23,7 +23,7 @@ protected function registerCompilerPass(ContainerBuilder $container): void
     /**
      * @test
      */
-    public function ifCompilerPassCollectsServicesByArgumentTheseWillExist()
+    public function ifCompilerPassCollectsServicesByArgumentTheseWillExist(): void
     {
         $collectingService = new Definition();
         $this->setDefinition('jms_translation.extractor_manager', $collectingService);

Tests/DependencyInjection/Compiler/MountFileVisitorsPassTest.php

@@ -23,7 +23,7 @@ protected function registerCompilerPass(ContainerBuilder $container): void
     /**
      * @test
      */
-    public function ifCompilerPassCollectsServicesByArgumentTheseWillExist()
+    public function ifCompilerPassCollectsServicesByArgumentTheseWillExist(): void
     {
         $collectingService = new Definition();
         $this->setDefinition('jms_translation.extractor.file_extractor', $collectingService);

Tests/DependencyInjection/Compiler/MountLoadersPassTest.php

@@ -23,7 +23,7 @@ protected function registerCompilerPass(ContainerBuilder $container): void
     /**
      * @test
      */
-    public function ifCompilerPassCollectsServicesByArgumentTheseWillExist()
+    public function ifCompilerPassCollectsServicesByArgumentTheseWillExist(): void
     {
         $collectingService = new Definition();
         $this->setDefinition('jms_translation.loader_manager', $collectingService);

Tests/DependencyInjection/JMSTranslationExtensionTest.php

@@ -22,7 +22,7 @@ protected function getContainerExtensions(): array
     /**
      * @test
      */
-    public function defaultParametersAfterLoading()
+    public function defaultParametersAfterLoading(): void
     {
         $this->load();
 
@@ -32,7 +32,7 @@ public function defaultParametersAfterLoading()
     /**
      * @test
      */
-    public function basicParametersAfterLoading()
+    public function basicParametersAfterLoading(): void
     {
         $locales = ['en', 'fr', 'es'];
         $this->load(['source_language' => 'fr', 'locales' => $locales]);

Tests/Functional/AppKernel.php

@@ -69,7 +69,7 @@ public function registerBundles(): iterable
         ];
     }
 
-    public function registerContainerConfiguration(LoaderInterface $loader)
+    public function registerContainerConfiguration(LoaderInterface $loader): void
     {
         $loader->load($this->fwConfig);
         if ($this->config) {

Tests/Functional/Command/BaseCommandTestCase.php

@@ -25,7 +25,7 @@
 
 abstract class BaseCommandTestCase extends BaseTestCase
 {
-    protected function getApp(array $options = [])
+    protected function getApp(array $options = []): Application
     {
         $kernel = $this->createKernel($options);
         $kernel->boot();

Tests/Functional/Command/ExtractCommandTest.php

@@ -25,7 +25,7 @@
 
 class ExtractCommandTest extends BaseCommandTestCase
 {
-    public function testExtract()
+    public function testExtract(): void
     {
         $input = new ArgvInput([
             'app/console',
@@ -58,7 +58,7 @@ public function testExtract()
         $this->assertTrue(isset($files['messages']['en']));
     }
 
-    public function testExtractDryRun()
+    public function testExtractDryRun(): void
     {
         $input = new ArgvInput([
             'app/console',

Tests/Functional/Command/Output.php

@@ -26,7 +26,7 @@ class Output extends AbstractOutput
 {
     private $content = '';
 
-    public function doWrite($content, $newline)
+    public function doWrite($content, $newline): void
     {
         $this->content .= $content;
 

Tests/Functional/Controller/ApiControllerTest.php

@@ -13,7 +13,7 @@
  */
 class ApiControllerTest extends BaseTestCase
 {
-    public function testUpdateAction()
+    public function testUpdateAction(): void
     {
         // Start application
         $client    = static::createClient(['config' => 'test_updating_translations.yml']);