Replace in_array() with isset() for nested groups in GroupsExclusionStrategy

When nestedGroups is enabled, shouldSkipProperty() used in_array() O(n) to check group membership. Build a hashmap from getGroupsFor() result and use isset() O(1) instead.

Author: NikoGrano

src/Exclusion/GroupsExclusionStrategy.php

@@ -54,11 +54,29 @@ public function shouldSkipProperty(PropertyMetadata $property, Context $navigato
         if ($this->nestedGroups) {
             $groups = $this->getGroupsFor($navigatorContext);
 
+            $groupsMap = [];
+            foreach ($groups as $k => $v) {
+                if (is_string($k)) {
+                    // nested group entry (key = property name, value = sub-groups)
+                    continue;
+                }
+
+                if (is_string($v)) {
+                    $groupsMap[$v] = true;
+                }
+            }
+
             if (!$property->groups) {
-                return !in_array(self::DEFAULT_GROUP, $groups);
+                return !isset($groupsMap[self::DEFAULT_GROUP]);
             }
 
-            return $this->shouldSkipUsingGroups($property, $groups);
+            foreach ($property->groups as $group) {
+                if (isset($groupsMap[$group])) {
+                    return false;
+                }
+            }
+
+            return true;
         } else {
             if (!$property->groups) {
                 return !isset($this->groups[self::DEFAULT_GROUP]);
@@ -74,17 +92,6 @@ public function shouldSkipProperty(PropertyMetadata $property, Context $navigato
         }
     }
 
-    private function shouldSkipUsingGroups(PropertyMetadata $property, array $groups): bool
-    {
-        foreach ($property->groups as $group) {
-            if (in_array($group, $groups)) {
-                return false;
-            }
-        }
-
-        return true;
-    }
-
     public function getGroupsFor(Context $navigatorContext): array
     {
         if (!$this->nestedGroups) {