fix getters included in mappable fields

Author: schultek

packages/dart_mappable/test/initializer/init_package_test.init.dart

@@ -0,0 +1,24 @@
+import 'package:dart_mappable/dart_mappable.dart';
+import 'package:test/test.dart';
+
+part 'with_getters_test.mapper.dart';
+
+@MappableClass()
+class ClassWithGetters with ClassWithGettersMappable {
+  final String name;
+  final int count;
+
+  ClassWithGetters(this.name, this.count);
+
+  String get message => 'Hello, $name!';
+  bool get hasItems => count > 0;
+}
+
+void main() {
+  group('basic class with getters', () {
+    test('encodes only fields', () {
+      var obj = ClassWithGetters('Kilian', 3);
+      expect(obj.toMap(), {'name': 'Kilian', 'count': 3});
+    });
+  });
+}

packages/dart_mappable/test/serialization/with_getters_test.dart

@@ -155,19 +155,17 @@ abstract class ClassMapperElement extends InterfaceMapperElement<ClassElement2>
     yield* extendsElement?._allFields ?? [];
 
     for (var getter in element.getters2) {
-      if (getter.isStatic) continue;
+      if (getter.isStatic || getter.isSynthetic) continue;
 
-      if (getter.isPublic || fieldChecker.hasAnnotationOf(getter)) {
+      if (fieldChecker.hasAnnotationOf(getter)) {
         yield getter.variable3!;
       }
     }
 
     for (var field in element.fields2) {
-      if (field.isStatic) continue;
+      if (field.isStatic || field.isSynthetic) continue;
 
-      if (field.isPublic && field.isSynthetic) {
-        yield field;
-      } else if (fieldChecker.hasAnnotationOf(field)) {
+      if (field.isPublic || fieldChecker.hasAnnotationOf(field)) {
         yield field;
       }
     }